Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Message.toString format, close #1676 #1677

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Update the Message.toString format, close #1676 #1677

merged 1 commit into from
Dec 27, 2018

Conversation

suntong
Copy link
Contributor

@suntong suntong commented Dec 26, 2018

change the Message.toString format, ref #1676

I'm submitting a...

[ ] Bug Fix
[ ] Feature
[X] Other (Refactoring, Added tests, Documentation, ...)

Description

Minor format change.
Ref #1676

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@suntong
Update message.ts
cf9cd6e 
change the Message.toString format, ref wechaty#1676
@huan huan requested a review from a team December 26, 2018 18:30
@huan
Copy link
Member

huan commented Dec 26, 2018

Please get at least one approvement from our contributors, then I'll be able to merge this PR for you.

Thanks.

@suntong
Copy link
Contributor Author

suntong commented Dec 26, 2018

Oh, I forgot that. @lijiarui, @windmemory, @zhuangbiaowei, @JasLin, @hiwanz, any one can help please? Thx.

zhuangbiaowei
zhuangbiaowei approved these changes Dec 27, 2018
View reviewed changes
Copy link

@zhuangbiaowei zhuangbiaowei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

如果能够有分不同消息类型输出的string，会更好。

@huan
Copy link
Member

huan commented Dec 27, 2018

Thanks @windmemory @zhuangbiaowei for the approvements.

@huan huan merged commit b6d32d2 into wechaty:master Dec 27, 2018
@suntong suntong mentioned this pull request Dec 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windmemory windmemory windmemory approved these changes

@zhuangbiaowei zhuangbiaowei zhuangbiaowei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suntong @huan @zhuangbiaowei @windmemory