Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix room mention #1666

Merged
merged 2 commits into from
Dec 1, 2018
Merged

Fix room mention #1666

merged 2 commits into from
Dec 1, 2018

Conversation

lhr0909
Copy link

@lhr0909 lhr0909 commented Nov 30, 2018

I'm submitting a...

[x] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Trying to resolve #1665

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

The mention list variables are completely misused, fixing them so we can actually use the feature properly.

Tested locally with BROLOG_LEVEL=silly with extra console logs to verify that the variables are properly passed through.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@lhr0909
Copy link
Author

lhr0909 commented Nov 30, 2018

I really don't feel like writing a test for it, testing alone takes out most of my energy. Please advice.

@huan huan requested a review from windmemory December 1, 2018 15:56
@huan
Copy link
Member

huan commented Dec 1, 2018

@lhr0909 Good catch! Thanks for fixing it.

I'll merge this PR after @windmemory approved it.

The unit test is better to have, but it's ok to leave it as is. Hopefully, we will have enough resources to cover them in the future.

@huan huan merged commit eab15a8 into wechaty:master Dec 1, 2018
@huan
Copy link
Member

huan commented Dec 1, 2018

@windmemory Thanks!

@huan
Copy link
Member

huan commented Dec 2, 2018

@lhr0909 thanks for the contribution!

Would you like to talk with other contributors in our private team wechat group?

If you'd like to, please contact @lijiarui and she can help you to get the invitation, thanks and welcome!

@huan
Copy link
Member

huan commented Dec 2, 2018

@lhr0909

You've invited Simon Liang to Chatie! They'll be receiving an email shortly. They can also visit https://github.com/Chatie to accept the invitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Room.say method is not working
3 participants