-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Message.mention() #1661
fix: Message.mention() #1661
Conversation
@windmemory Could you please help @jzj1993 to review this PR? If you could, then I hope to merge this one with yours at the same time. Thank you very much. |
This build is broken by typescript upgrade I believe, it now will parse the fake function and check the type on it. In my PR, I fixed that issue, so I would suggest to merge my change first, then rebase this change onto master to see whether the build get fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides that, you forgot to modify the logic in room.ts
, which also support the say
function, please add that change as well. Thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a close review on the logic, I think the change looks good. The FOUR_PRE_EM_SPACE
is used in room.say()
, but not in message.say()
, it confused me, but not related to this change.
Approved.
@windmemory Thanks for the review and approvement! |
@jzj1993 Could you add my wechat: |
@lijiarui Thanks for following up. @jzj1993 I have sent you an invitation for joining the Chatie Org on Github, please check your email or just follow the instruction below:
|
I'm submitting a...
Checklist
Description
Fix message.mention() bug on PC/Mac.
AT_SEPERATOR
should be "\u0020" if message is sent from PC/Mac, and "\u2005" from mobile:This bug is already mentioned here:
Does this PR introduce a breaking change?