add room-bot test code #1338
Merged
add room-bot test code #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huan
requested changes
Jun 15, 2018
examples/room-bot.ts
Outdated
| log.info('Bot', 'onMessage: sender has already in dingRoom') | ||
| from.say('no need to ding again, because you are already in ding room') | ||
| dingRoom.say('no need to ding again, because you are already in ding room', from) | ||
| from.say(`I found you have joined in room ${topic}!`) |
There was a problem hiding this comment.
Add '"' around all variable values.
- from.say(`I found you have joined in room ${topic}!`)
+ from.say(`I found you have joined in room "${topic}!"`)
huan
requested changes
Jun 15, 2018
examples/room-bot.ts
Outdated
| log.info('Bot', 'onMessage: sender has already in dingRoom') | ||
| from.say('no need to ding again, because you are already in ding room') | ||
| dingRoom.say('no need to ding again, because you are already in ding room', from) | ||
| from.say(`I found you have joined in room "${topic}"!`) |
There was a problem hiding this comment.
I'll not merge this PR unless you are not as "too smart" as right now...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes testing
room-bot.tsmore convenient.test function list: wechaty/wechaty-puppet-padchat#63