room mention contact should using roomAlias

[kis87988]

Purpose:
For now,
Our room.say(content,contact) will call contact name, but if contact has room alias, it should do room alias.
the order should be roomAlias > name. If the contact not set roomAlias, it would be name.
Is this a good idea? if so, I can do this PR

[huan]

Yes, the idea is the right direction that we should go.

PR is welcome.

[huan]

PR merged.

Thanks for your contribution!

[huan]

Your code has a bug with the alias(), I had fixed in the latest commit.

In short: alias() will return a Promise that you should await, or you will never get the chance to call name()

- this.alias(c) || c.name()
+ await this.alias(c) || c.name()

And that's the reason why your typing is not right. Instead of checking it again for the real reason, you go to the wrong direction one more step: force casting the type, which should normally be avoided.

Please have a look at the new code, and feel free to ask if you have more questions.

Thanks!

[kis87988]

I see! That is why.
Thank you. I have learned a lesson 👍

[huan]

We had added an additional check for this special case: we do not allow to use promise as boolean anymore.

@lijiarui Maybe you will want this feature too.

ERROR: /Users/zixia/chatie/wechaty/src/user/room.ts[437, 52]: Promises should be awaited when used in boolean expressions

See: microsoft/tslint-microsoft-contrib#174 (comment)