Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite roomFindAll() #1255

Closed
lijiarui opened this issue May 30, 2018 · 3 comments
Closed

rewrite roomFindAll() #1255

lijiarui opened this issue May 30, 2018 · 3 comments
Assignees
@lijiarui
Labels
enhancement
Milestone
v0.18 Connecting ...

Comments

@lijiarui
Copy link
Member

#1249

should complete the roomFindAll()
@lijiarui lijiarui mentioned this issue May 30, 2018
Closed
9 tasks
@huan
Copy link
Member

huan commented May 31, 2018 •
edited
Loading

Good news: there will be not necessary to implement roomFindAll() for a puppet for now.

You need to implement roomList() instead, should return all roomId as a string[].

Know more from the following commit message.

huan added a commit that referenced this issue May 31, 2018
@huan
roomList() insteadof roomFindAll() (#1255)
15919af
@huan huan mentioned this issue May 31, 2018
Closed
@huan huan assigned lijiarui and unassigned huan May 31, 2018
@huan
Copy link
Member

huan commented Jun 8, 2018

Done. Please close this issue if all is ok.

@lijiarui
Copy link
Member Author

all is ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lijiarui lijiarui

Labels
enhancement
Projects
None yet
Milestone
v0.18 Connecting with the Cloud & App
Development

No branches or pull requests
2 participants
@huan @lijiarui