Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot-reload-bot adding hot-reloading config #1100

Closed
suntong opened this issue Feb 19, 2018 · 4 comments
Closed

hot-reload-bot adding hot-reloading config #1100

suntong opened this issue Feb 19, 2018 · 4 comments

Comments

@suntong
Copy link
Contributor

suntong commented Feb 19, 2018

The hot-reload-bot demo code only hot-reload event handling scripts, however, most event handling will need some kind of configuration, so it is nice to hot-reload configurations as well.

Do you already have some code exist to handle that @Gcaufy? Would you care to update the demo if you do please?

Otherwise, I'll see if I can do something, if it is OK, @Gcaufy, @zixia. But mind you, I've never written any Javascript programs before.

@huan
Copy link
Member

huan commented Feb 20, 2018

Thanks for your idea.

PR is welcome. :)

@suntong
Copy link
Contributor Author

suntong commented Feb 24, 2018

Ok, I'll look into it, since @Gcaufy don't have the extra bandwidth.

When asking the question, I was thinking to send in PR for the hot-reload-bot demo code, but now, after thinking it over these period, I'm planning to submit a different demo instead, It's is still based on @Gcaufy's hot-reload-bot demo, but will be much more to it, so that's the main reason. What will be included in the new demo will be a turn key solution of getting started with serious wechaty customization blue-print.

  • Pure ES6 code, no Typescript, as per @Gcaufy's existing code
  • All even handling, as per @Gcaufy's existing code
  • Hot-reload even handling code, as per @Gcaufy's existing code
  • Hot-reload configurations as well
  • emoji cleansing -- to simplify emoji from <img class="qqemoji qqemoji13" text="[呲牙]_web" src="https://wx.qq.com/zh_CN/htmledition/v2/images/spacer.gif" /> to merely [呲牙]
  • Auto-save all media files, i.e., incorporate media-file-bot.ts into this getting started demo
  • Graceful exit on SIGINT/SIGTERM, i.e., to write key info into file, on receiving killing signals (e.g., SIGINT (2), SIGTERM(3)), before termination, so as to do a "graceful shutdown".

All in all, it's be a true solution for people to get started using wechaty, a one-stop demo for people to get an easy start.

@suntong
Copy link
Contributor Author

suntong commented Feb 26, 2018

oh, on seeing the issues in

I realize that I'm not anywhere near the position to provide such demo...

huan added a commit that referenced this issue Feb 26, 2018
@suntong
Copy link
Contributor Author

suntong commented Mar 7, 2018

OK. work started, ref: https://github.com/suntong/wechaty/commits/m1
which will eventually be merged back (after I'm done)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants