Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of common localStorage variable UID #32

Open
rvbz opened this issue Dec 6, 2019 · 3 comments
Open

Usage of common localStorage variable UID #32

rvbz opened this issue Dec 6, 2019 · 3 comments

Comments

@rvbz
Copy link

rvbz commented Dec 6, 2019

Hello,

The script makes usage of general localStorage variable names like "uid" which can present a problem when using with different other plugins and scripts.
It's always a good practice to set those variable names with specific and almost a unique way to avoid clashing with other scripts, e.g. "profanityFilter_uid"

@ChaseFlorell
Copy link
Owner

have you found this to actually conflict?

@rvbz
Copy link
Author

rvbz commented Dec 6, 2019

Of course, otherwise I wouldn't be posting an issue.

@ChaseFlorell
Copy link
Owner

can you describe your issue? the var uid is scoped to the localStorageIsEnabled function.
But if you're having an issue, I'll happily take a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants