From 9364017aa69c9da2b78dd84ae73224f59f4c86a3 Mon Sep 17 00:00:00 2001 From: Scalman Date: Sun, 16 Jun 2019 16:46:34 +0200 Subject: [PATCH 1/2] fixed stacked chart bug when there are different stacks on columns. --- Source/Charts/Renderers/BarChartRenderer.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Charts/Renderers/BarChartRenderer.swift b/Source/Charts/Renderers/BarChartRenderer.swift index 6b192051bb..40f717691a 100644 --- a/Source/Charts/Renderers/BarChartRenderer.swift +++ b/Source/Charts/Renderers/BarChartRenderer.swift @@ -869,7 +869,7 @@ open class BarChartRenderer: BarLineScatterCandleBubbleRenderer } elementValueText = dataSet.valueFormatter?.stringForValue( - vals[idx % stackSize], + vals[idx % vals.count], entry: e, dataSetIndex: dataSetIndex, viewPortHandler: viewPortHandler) ?? "\(e.y)" From 40f0dd884357bb7ae2d01c196ef7a628f38ff082 Mon Sep 17 00:00:00 2001 From: Scalman Date: Mon, 15 Jul 2019 21:28:17 +0200 Subject: [PATCH 2/2] added empty array check --- Source/Charts/Renderers/BarChartRenderer.swift | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Source/Charts/Renderers/BarChartRenderer.swift b/Source/Charts/Renderers/BarChartRenderer.swift index 40f717691a..e675ba2215 100644 --- a/Source/Charts/Renderers/BarChartRenderer.swift +++ b/Source/Charts/Renderers/BarChartRenderer.swift @@ -867,9 +867,12 @@ open class BarChartRenderer: BarLineScatterCandleBubbleRenderer } else { stackLabel = nil } - + + //Handles empty array of yValues + let yValue = vals.isEmpty ? 0.0 : vals[idx % vals.count] + elementValueText = dataSet.valueFormatter?.stringForValue( - vals[idx % vals.count], + yValue, entry: e, dataSetIndex: dataSetIndex, viewPortHandler: viewPortHandler) ?? "\(e.y)"