rework bitmap image rendering simulation #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork-bitmap-image-rendering-simulation
…ractErikaMock; fix tests
…ap-image-rendering-simulation Conflicts: erika/erika_mock.py
do not throw in finally block if erika init fails
| @@ -39,6 +39,8 @@ set -x | |||
|
|
|||
| ./erika.sh render_ascii_art -h | |||
| ./erika.sh render_ascii_art -d -f ./tests/test_resources/test_ascii_art.txt | |||
| # FIXME | |||
sirexeclp
reviewed
Jan 15, 2020
Comment on lines
-140
to
+149
| erika = CharacterBasedErikaMock(DRY_RUN_WIDTH, DRY_RUN_HEIGHT, delay_after_each_step=DRY_RUN_DELAY, | ||
| exception_if_overprinted=False) | ||
| erika = CharacterBasedErikaMock(DRY_RUN_WIDTH, DRY_RUN_HEIGHT, delay_after_each_step=DRY_RUN_DELAY) | ||
| else: | ||
| # a bit hacky, as I'm mirroring behavior from ErikaImageRenderer - this kindof goes against the now-beautiful architecture :( | ||
| try: | ||
| # hacky: use exception to determine image type | ||
| image_for_provoking_exception = WrappedImage(args.file) | ||
| erika = MicrostepBasedErikaMock(DRY_RUN_WIDTH, DRY_RUN_HEIGHT, output_after_each_step=True, | ||
| delay_after_each_step=DRY_RUN_DELAY, exception_if_overprinted=False) | ||
| erika = MicrostepBasedErikaMock(DRY_RUN_WIDTH, DRY_RUN_HEIGHT, delay_after_each_step=DRY_RUN_DELAY) | ||
| except NotAnImageException: | ||
| erika = CharacterBasedErikaMock(DRY_RUN_WIDTH, DRY_RUN_HEIGHT, delay_after_each_step=DRY_RUN_DELAY, | ||
| exception_if_overprinted=False) | ||
| erika = CharacterBasedErikaMock(DRY_RUN_WIDTH, DRY_RUN_HEIGHT, delay_after_each_step=DRY_RUN_DELAY) |
There was a problem hiding this comment.
Sane defaults would be nice here, so that parameter-less ctor.
Limiting the hight might not make much sense, because we use endless paper with hardware.
There was a problem hiding this comment.
discussed:
To be done in #69
cyroxx
pushed a commit
to cyroxx/erika3004
that referenced
this pull request
Feb 1, 2020
…ure/rework-bitmap-image-rendering-simulation rework bitmap image rendering simulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements issue #60
MUST BE DONE AFTER #52 !