Migrate data type conversion utils functions from 1.x #4405
Conversation
nazarhussain
force-pushed
the
nh/4350-web3-utils-converters
branch
from
cae2258
to
e5830a7
Compare
| tether: expo10(30), | ||
| }; | ||
|
|
||
| const errorMessage = (value: unknown, error: string) => |
There was a problem hiding this comment.
I would think this should be defined in errors.ts to be used by all the inline errors below
|
Since we are replacing As it looks like we are removing the |
|
@luu-alex Yes we are replacing |
| if (numberOfZerosInDenomination <= 0) { | ||
| return number.toString(); | ||
| } |
There was a problem hiding this comment.
I don't understand what's happening here, could you clarify with a comment?
There was a problem hiding this comment.
Oh I think I understand, this handles if the provided unit is wei or noether?
There was a problem hiding this comment.
Yes you are right.
|
|
||
| // value in wei would always be integer | ||
| // 13456789, 1234 | ||
| const value = String(toNumber(number)); |
There was a problem hiding this comment.
Is all the casting necessary? Above you just do number.toString()
There was a problem hiding this comment.
The input number is of type Numbers which is better to be casted with toNumber as it could include HexString as well.
Description
Create conversion functions for
web3-utilsFixes #4350
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.