Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal memory allocation for ViewDU batch hash #386

Closed
twoeths opened this issue Jul 19, 2024 · 0 comments
Closed

Minimal memory allocation for ViewDU batch hash #386

twoeths opened this issue Jul 19, 2024 · 0 comments
Assignees

Comments

@twoeths
Copy link
Contributor

twoeths commented Jul 19, 2024

Is your feature request related to a problem? Please describe.

batch hash work is in progress, this is how it looks in a lodestar node every time we get through epoch transition

  • 6h chart
Screenshot 2024-07-19 at 08 18 18
  • 10m chart
Screenshot 2024-07-19 at 08 23 36

looks like memory allocation is an issue there and it caused some spiked hash_tree_root times

Describe the solution you'd like

right now we allocate memory every time we compute ViewDU.hashTreeRoot(), find a way to do minimal memory allocation and reuse it over time

Additional context

  • tested branch: te/batch_hash_tree_root
@twoeths twoeths self-assigned this Jul 19, 2024
@twoeths twoeths changed the title Minimal memory allocation for batch hash Minimal memory allocation for ViewDU batch hash Jul 19, 2024
@twoeths twoeths closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant