Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add enableSwaps in transferWithHook and transfer #97

Merged
merged 10 commits into from
Dec 11, 2024
Merged

feat: add enableSwaps in transferWithHook and transfer #97

merged 10 commits into from
Dec 11, 2024
+29 −2

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Dec 6, 2024 •
edited
Loading

closes #94

  • my linter (or prettier) removed trailing commas, making this PR look bigger than it seems, I've set it as a rule.

@Tbaut Tbaut changed the title Add enableSwaps in transferWithHook and transfer feat: add enableSwaps in transferWithHook and transfer Dec 6, 2024
@github-actions github-actions bot temporarily deployed to gopher-poc (Preview) December 6, 2024 16:02 Inactive
@github-actions github-actions bot temporarily deployed to gopher-docs-preview (Preview) December 6, 2024 16:02 Inactive
@BeroBurny
Copy link
Collaborator

  • enableSwaps is optional, but I'm not setting it as falseper default, if it's undefined, the api side will take it as falsy I believe. Is that ok or should I explicitely set it to false in the makeRequest?

I went through implementation and it seems this could be an issue (not a GO dev so I could be wrong), but it should be defaulted on API as it is a new feature not to break older integrations

It seems it has not yet been deployed on production

BeroBurny
BeroBurny requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • is the doc set manually like I did, or do you take it from somewhere else?

Documentation is not automated, you need to update it manually

  • docs/docs/03-sdk/04-methods-reference/transfer

@github-actions github-actions bot temporarily deployed to gopher-docs-preview (Preview) December 9, 2024 14:57 Inactive
@github-actions github-actions bot temporarily deployed to gopher-poc (Preview) December 9, 2024 14:59 Inactive
@github-actions github-actions bot temporarily deployed to gopher-docs-preview (Preview) December 9, 2024 14:59 Inactive
@Tbaut
Copy link
Collaborator Author

Tbaut commented Dec 9, 2024

Thanks Bero. I've now set it to false per default.
I've updated the docs too.

I realized the docs aren't really linted, I'll do this in another PR, otherwise every time I save, prettier changes everything.

@Tbaut Tbaut requested a review from BeroBurny December 9, 2024 15:01
BeroBurny
BeroBurny reviewed Dec 10, 2024
View reviewed changes
packages/sdk/src/api.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to gopher-poc (Preview) December 10, 2024 09:15 Inactive
@github-actions github-actions bot temporarily deployed to gopher-docs-preview (Preview) December 10, 2024 09:16 Inactive
Tbaut added a commit that referenced this pull request Dec 10, 2024
@Tbaut
use same prettier as for #97
bd92d95
@Tbaut Tbaut requested review from mpetrunic and BeroBurny December 10, 2024 13:16
@github-actions github-actions bot temporarily deployed to gopher-poc (Preview) December 10, 2024 13:17 Inactive
@github-actions github-actions bot temporarily deployed to gopher-docs-preview (Preview) December 10, 2024 13:18 Inactive
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployment Completed

Docs: View Deployment -> https://a5f1b8d8.sprinter-docs.pages.dev
POC: View Deployment -> https://dd4cfa12.sprinter-poc.pages.dev

@Tbaut Tbaut requested a review from BeroBurny December 10, 2024 18:18
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployment Completed

Docs: View Deployment -> https://6396917f.sprinter-docs.pages.dev
POC: View Deployment -> https://23a71732.sprinter-poc.pages.dev

@Tbaut Tbaut merged commit bd21311 into master Dec 11, 2024
4 checks passed
@Tbaut Tbaut deleted the tbaut-enableSwaps branch December 11, 2024 08:36
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Merged
mpetrunic pushed a commit that referenced this pull request Dec 11, 2024
@github-actions
chore: release master (#92)
c21cd9e 
🤖 I have created a release *beep* *boop*
---


<details><summary>sprinter-sdk: 1.1.0</summary>

##
[1.1.0](sprinter-sdk-v1.0.2...sprinter-sdk-v1.1.0)
(2024-12-11)


### Features

* add enableSwaps in `transferWithHook` and `transfer`
([#97](#97))
([bd21311](bd21311)),
closes [#94](#94)
</details>

<details><summary>sprinter-react: 1.1.0</summary>

##
[1.1.0](sprinter-react-v1.0.0...sprinter-react-v1.1.0)
(2024-12-11)


### Features

* add enableSwaps in `transferWithHook` and `transfer`
([#97](#97))
([bd21311](bd21311)),
closes [#94](#94)


### Bug Fixes

* **PoC:** readme, some errors and other nits
([#90](#90))
([f4fb199](f4fb199))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
Merged
Tbaut added a commit that referenced this pull request Jan 16, 2025
@github-actions @Tbaut
chore(): release master (#117)
9345c72 
🤖 I have created a release *beep* *boop*
---


<details><summary>docs: 1.0.0</summary>

##
[1.0.0](docs-v0.0.1...docs-v1.0.0)
(2025-01-13)


### ⚠ BREAKING CHANGES

* All functions renamed, different API and flows, please consult docs or
reach out to us directly!

### Features

* add enableSwaps in `transferWithHook` and `transfer`
([#97](#97))
([bd21311](bd21311)),
closes [#94](#94)
* add relay to the docs
([#103](#103))
([310c506](310c506))
* Add sweep function
([#115](#115))
([efaaa2b](efaaa2b)),
closes [#110](#110)
* cross chain contract call
([#21](#21))
([69c0128](69c0128))
* depricate provider param from sdk
([#41](#41))
([72297fe](72297fe))
* docs POC ([#14](#14))
([8cd800d](8cd800d))
* dynamic supported network and tokens in docs
([#32](#32))
([abe5618](abe5618)),
closes [#29](#29)
* erc20 with contract call
([#39](#39))
([77e1d8d](77e1d8d)),
closes [#38](#38)
* native tokens transfers
([#40](#40))
([d4edf35](d4edf35)),
closes [#36](#36)
* refactor api
([#61](#61))
([d6b1e9c](d6b1e9c))
</details>

<details><summary>sprinter-sdk: 1.2.0</summary>

##
[1.2.0](sprinter-sdk-v1.1.2...sprinter-sdk-v1.2.0)
(2025-01-13)


### Features

* Add sweep function
([#115](#115))
([efaaa2b](efaaa2b)),
closes [#110](#110)


### Bug Fixes

* webpack import meta error
([#114](#114))
([f5f6fcf](f5f6fcf))
</details>

<details><summary>sprinter-react: 1.2.0</summary>

##
[1.2.0](sprinter-react-v1.1.2...sprinter-react-v1.2.0)
(2025-01-13)


### Features

* Add sweep function
([#115](#115))
([efaaa2b](efaaa2b)),
closes [#110](#110)
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Thibaut Sardan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeroBurny BeroBurny BeroBurny approved these changes

@saadahmsiddiqui saadahmsiddiqui Awaiting requested review from saadahmsiddiqui

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add optional flag to enable source swaps for single hop solutions
3 participants
@Tbaut @BeroBurny @mpetrunic