Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup overrides for the biomejs configuration #7162

Merged
merged 4 commits into from
Oct 16, 2024
Merged

chore: cleanup overrides for the biomejs configuration #7162

merged 4 commits into from
Oct 16, 2024

Conversation

nazarhussain
Copy link
Contributor

Motivation

We discourage to override rules, if there are those should mention specific reasoning.

Description

  • Cleanup unnecessary override rules
  • Add explanation comments to all overriding rules
  • Add proper naming conventions for all kinds of objects

Steps to test or reproduce

  • Run all tests

@nazarhussain nazarhussain requested a review from a team as a code owner October 15, 2024 09:20
@nazarhussain nazarhussain self-assigned this Oct 15, 2024
@nazarhussain
Copy link
Contributor Author

Earlier most the conventions were disabled so we never check and validate.

lodestar/.eslintrc.js

Lines 54 to 66 in c26cc63

{
selector: [
"classProperty",
"objectLiteralProperty",
"typeProperty",
"classMethod",
"objectLiteralMethod",
"typeMethod",
"accessor",
"enumMember",
],
format: null,
modifiers: ["requiresQuotes"],

With biome, there is no way to disable formats, so why we have more detailed conventions list.

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.21%. Comparing base (5adb4ef) to head (45ecb57).
Report is 3 commits behind head on unstable.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #7162   +/-   ##
=========================================
  Coverage     49.20%   49.21%           
=========================================
  Files           598      598           
  Lines         39726    39726           
  Branches       2088     2092    +4     
=========================================
+ Hits          19549    19550    +1     
+ Misses        20137    20136    -1     
  Partials         40       40

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 8d8119f Previous: 5adb4ef Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.2986 ms/op 1.9345 ms/op 1.19
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 75.367 us/op 44.291 us/op 1.70
BLS verify - blst 917.47 us/op 746.00 us/op 1.23
BLS verifyMultipleSignatures 3 - blst 1.5218 ms/op 1.1363 ms/op 1.34
BLS verifyMultipleSignatures 8 - blst 1.7531 ms/op 1.6142 ms/op 1.09
BLS verifyMultipleSignatures 32 - blst 5.3665 ms/op 4.6730 ms/op 1.15
BLS verifyMultipleSignatures 64 - blst 9.1767 ms/op 8.7578 ms/op 1.05
BLS verifyMultipleSignatures 128 - blst 17.768 ms/op 16.735 ms/op 1.06
BLS deserializing 10000 signatures 702.51 ms/op 669.62 ms/op 1.05
BLS deserializing 100000 signatures 7.0577 s/op 6.7787 s/op 1.04
BLS verifyMultipleSignatures - same message - 3 - blst 1.0126 ms/op 866.95 us/op 1.17
BLS verifyMultipleSignatures - same message - 8 - blst 1.2200 ms/op 989.49 us/op 1.23
BLS verifyMultipleSignatures - same message - 32 - blst 1.9516 ms/op 1.6136 ms/op 1.21
BLS verifyMultipleSignatures - same message - 64 - blst 2.9498 ms/op 2.5068 ms/op 1.18
BLS verifyMultipleSignatures - same message - 128 - blst 4.7542 ms/op 4.2273 ms/op 1.12
BLS aggregatePubkeys 32 - blst 21.991 us/op 19.730 us/op 1.11
BLS aggregatePubkeys 128 - blst 76.509 us/op 68.852 us/op 1.11
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 77.459 ms/op 63.980 ms/op 1.21
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 71.437 ms/op 51.814 ms/op 1.38
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 46.320 ms/op 39.360 ms/op 1.18
getSlashingsAndExits - default max 125.18 us/op 93.635 us/op 1.34
getSlashingsAndExits - 2k 324.73 us/op 270.69 us/op 1.20
proposeBlockBody type=full, size=empty 6.8021 ms/op 6.0771 ms/op 1.12
isKnown best case - 1 super set check 372.00 ns/op 303.00 ns/op 1.23
isKnown normal case - 2 super set checks 465.00 ns/op 302.00 ns/op 1.54
isKnown worse case - 16 super set checks 432.00 ns/op 281.00 ns/op 1.54
InMemoryCheckpointStateCache - add get delete 3.2470 us/op 2.7460 us/op 1.18
updateUnfinalizedPubkeys - updating 10 pubkeys 1.4534 ms/op 914.93 us/op 1.59
updateUnfinalizedPubkeys - updating 100 pubkeys 4.2758 ms/op 4.1197 ms/op 1.04
updateUnfinalizedPubkeys - updating 1000 pubkeys 56.480 ms/op 54.875 ms/op 1.03
validate api signedAggregateAndProof - struct 1.5362 ms/op 1.4052 ms/op 1.09
validate gossip signedAggregateAndProof - struct 1.5014 ms/op 1.3421 ms/op 1.12
batch validate gossip attestation - vc 640000 - chunk 32 136.28 us/op 127.55 us/op 1.07
batch validate gossip attestation - vc 640000 - chunk 64 124.18 us/op 109.03 us/op 1.14
batch validate gossip attestation - vc 640000 - chunk 128 117.15 us/op 105.39 us/op 1.11
batch validate gossip attestation - vc 640000 - chunk 256 119.77 us/op 104.35 us/op 1.15
pickEth1Vote - no votes 1.3605 ms/op 1.0736 ms/op 1.27
pickEth1Vote - max votes 9.1492 ms/op 8.0635 ms/op 1.13
pickEth1Vote - Eth1Data hashTreeRoot value x2048 17.117 ms/op 17.440 ms/op 0.98
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.957 ms/op 19.358 ms/op 1.19
pickEth1Vote - Eth1Data fastSerialize value x2048 590.40 us/op 505.06 us/op 1.17
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.3755 ms/op 3.1601 ms/op 1.38
bytes32 toHexString 688.00 ns/op 472.00 ns/op 1.46
bytes32 Buffer.toString(hex) 283.00 ns/op 259.00 ns/op 1.09
bytes32 Buffer.toString(hex) from Uint8Array 490.00 ns/op 414.00 ns/op 1.18
bytes32 Buffer.toString(hex) + 0x 268.00 ns/op 256.00 ns/op 1.05
Object access 1 prop 0.19700 ns/op 0.15800 ns/op 1.25
Map access 1 prop 0.14500 ns/op 0.13000 ns/op 1.12
Object get x1000 6.2100 ns/op 5.7660 ns/op 1.08
Map get x1000 6.9040 ns/op 6.5730 ns/op 1.05
Object set x1000 38.764 ns/op 32.286 ns/op 1.20
Map set x1000 25.244 ns/op 21.379 ns/op 1.18
Return object 10000 times 0.30920 ns/op 0.29090 ns/op 1.06
Throw Error 10000 times 3.4544 us/op 3.3340 us/op 1.04
toHex 176.01 ns/op 149.60 ns/op 1.18
Buffer.from 168.19 ns/op 126.23 ns/op 1.33
shared Buffer 103.52 ns/op 90.858 ns/op 1.14
fastMsgIdFn sha256 / 200 bytes 2.4760 us/op 2.2480 us/op 1.10
fastMsgIdFn h32 xxhash / 200 bytes 299.00 ns/op 218.00 ns/op 1.37
fastMsgIdFn h64 xxhash / 200 bytes 289.00 ns/op 264.00 ns/op 1.09
fastMsgIdFn sha256 / 1000 bytes 7.6120 us/op 7.2470 us/op 1.05
fastMsgIdFn h32 xxhash / 1000 bytes 428.00 ns/op 355.00 ns/op 1.21
fastMsgIdFn h64 xxhash / 1000 bytes 365.00 ns/op 341.00 ns/op 1.07
fastMsgIdFn sha256 / 10000 bytes 64.891 us/op 64.861 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 1.9360 us/op 1.8430 us/op 1.05
fastMsgIdFn h64 xxhash / 10000 bytes 1.2500 us/op 1.2030 us/op 1.04
send data - 1000 256B messages 13.878 ms/op 11.886 ms/op 1.17
send data - 1000 512B messages 18.854 ms/op 15.757 ms/op 1.20
send data - 1000 1024B messages 29.502 ms/op 24.836 ms/op 1.19
send data - 1000 1200B messages 29.420 ms/op 26.423 ms/op 1.11
send data - 1000 2048B messages 37.192 ms/op 31.268 ms/op 1.19
send data - 1000 4096B messages 35.460 ms/op 32.592 ms/op 1.09
send data - 1000 16384B messages 92.678 ms/op 74.956 ms/op 1.24
send data - 1000 65536B messages 266.18 ms/op 214.52 ms/op 1.24
enrSubnets - fastDeserialize 64 bits 1.9310 us/op 1.1420 us/op 1.69
enrSubnets - ssz BitVector 64 bits 509.00 ns/op 385.00 ns/op 1.32
enrSubnets - fastDeserialize 4 bits 232.00 ns/op 155.00 ns/op 1.50
enrSubnets - ssz BitVector 4 bits 515.00 ns/op 359.00 ns/op 1.43
prioritizePeers score -10:0 att 32-0.1 sync 2-0 293.04 us/op 130.89 us/op 2.24
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 227.74 us/op 154.28 us/op 1.48
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 339.10 us/op 221.54 us/op 1.53
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 479.94 us/op 403.19 us/op 1.19
prioritizePeers score 0:0 att 64-1 sync 4-1 1.0943 ms/op 497.04 us/op 2.20
array of 16000 items push then shift 1.8096 us/op 1.6422 us/op 1.10
LinkedList of 16000 items push then shift 10.287 ns/op 7.1580 ns/op 1.44
array of 16000 items push then pop 161.05 ns/op 122.47 ns/op 1.32
LinkedList of 16000 items push then pop 8.8000 ns/op 7.1920 ns/op 1.22
array of 24000 items push then shift 2.6444 us/op 2.4687 us/op 1.07
LinkedList of 24000 items push then shift 10.074 ns/op 7.2170 ns/op 1.40
array of 24000 items push then pop 214.44 ns/op 154.18 ns/op 1.39
LinkedList of 24000 items push then pop 8.5180 ns/op 7.4620 ns/op 1.14
intersect bitArray bitLen 8 6.8710 ns/op 6.5570 ns/op 1.05
intersect array and set length 8 87.077 ns/op 45.335 ns/op 1.92
intersect bitArray bitLen 128 36.944 ns/op 30.952 ns/op 1.19
intersect array and set length 128 1.1224 us/op 736.52 ns/op 1.52
bitArray.getTrueBitIndexes() bitLen 128 2.4000 us/op 1.5670 us/op 1.53
bitArray.getTrueBitIndexes() bitLen 248 5.4400 us/op 2.5070 us/op 2.17
bitArray.getTrueBitIndexes() bitLen 512 9.7380 us/op 5.0330 us/op 1.93
Buffer.concat 32 items 1.1140 us/op 971.00 ns/op 1.15
Uint8Array.set 32 items 1.8630 us/op 1.5690 us/op 1.19
Buffer.copy 2.7880 us/op 1.8000 us/op 1.55
Uint8Array.set - with subarray 3.9560 us/op 2.5730 us/op 1.54
Uint8Array.set - without subarray 2.0980 us/op 1.3800 us/op 1.52
getUint32 - dataview 343.00 ns/op 250.00 ns/op 1.37
getUint32 - manual 298.00 ns/op 174.00 ns/op 1.71
Set add up to 64 items then delete first 3.4104 us/op 2.1586 us/op 1.58
OrderedSet add up to 64 items then delete first 5.3325 us/op 3.3374 us/op 1.60
Set add up to 64 items then delete last 3.7705 us/op 2.4863 us/op 1.52
OrderedSet add up to 64 items then delete last 5.2608 us/op 3.6123 us/op 1.46
Set add up to 64 items then delete middle 3.5790 us/op 2.5278 us/op 1.42
OrderedSet add up to 64 items then delete middle 7.9455 us/op 5.4796 us/op 1.45
Set add up to 128 items then delete first 8.2145 us/op 5.6183 us/op 1.46
OrderedSet add up to 128 items then delete first 13.082 us/op 8.1227 us/op 1.61
Set add up to 128 items then delete last 7.6413 us/op 5.6028 us/op 1.36
OrderedSet add up to 128 items then delete last 12.614 us/op 8.6548 us/op 1.46
Set add up to 128 items then delete middle 6.9579 us/op 5.5826 us/op 1.25
OrderedSet add up to 128 items then delete middle 17.086 us/op 15.600 us/op 1.10
Set add up to 256 items then delete first 14.584 us/op 13.552 us/op 1.08
OrderedSet add up to 256 items then delete first 22.890 us/op 18.140 us/op 1.26
Set add up to 256 items then delete last 13.229 us/op 10.930 us/op 1.21
OrderedSet add up to 256 items then delete last 20.353 us/op 15.841 us/op 1.28
Set add up to 256 items then delete middle 13.118 us/op 10.324 us/op 1.27
OrderedSet add up to 256 items then delete middle 48.920 us/op 42.871 us/op 1.14
transfer serialized Status (84 B) 1.5640 us/op 1.3990 us/op 1.12
copy serialized Status (84 B) 1.5040 us/op 1.1720 us/op 1.28
transfer serialized SignedVoluntaryExit (112 B) 1.7520 us/op 1.4710 us/op 1.19
copy serialized SignedVoluntaryExit (112 B) 1.5650 us/op 1.2020 us/op 1.30
transfer serialized ProposerSlashing (416 B) 1.9290 us/op 1.8160 us/op 1.06
copy serialized ProposerSlashing (416 B) 2.2540 us/op 1.5150 us/op 1.49
transfer serialized Attestation (485 B) 2.5830 us/op 1.5430 us/op 1.67
copy serialized Attestation (485 B) 2.3920 us/op 1.6320 us/op 1.47
transfer serialized AttesterSlashing (33232 B) 1.9530 us/op 1.7260 us/op 1.13
copy serialized AttesterSlashing (33232 B) 9.7810 us/op 4.8470 us/op 2.02
transfer serialized Small SignedBeaconBlock (128000 B) 2.8050 us/op 2.2410 us/op 1.25
copy serialized Small SignedBeaconBlock (128000 B) 27.916 us/op 13.373 us/op 2.09
transfer serialized Avg SignedBeaconBlock (200000 B) 3.3730 us/op 2.7910 us/op 1.21
copy serialized Avg SignedBeaconBlock (200000 B) 39.467 us/op 19.854 us/op 1.99
transfer serialized BlobsSidecar (524380 B) 3.3740 us/op 2.8260 us/op 1.19
copy serialized BlobsSidecar (524380 B) 162.27 us/op 83.484 us/op 1.94
transfer serialized Big SignedBeaconBlock (1000000 B) 3.8790 us/op 3.7640 us/op 1.03
copy serialized Big SignedBeaconBlock (1000000 B) 221.55 us/op 192.13 us/op 1.15
pass gossip attestations to forkchoice per slot 2.9580 ms/op 2.9356 ms/op 1.01
forkChoice updateHead vc 100000 bc 64 eq 0 462.27 us/op 466.76 us/op 0.99
forkChoice updateHead vc 600000 bc 64 eq 0 5.6228 ms/op 4.1153 ms/op 1.37
forkChoice updateHead vc 1000000 bc 64 eq 0 7.0120 ms/op 5.1858 ms/op 1.35
forkChoice updateHead vc 600000 bc 320 eq 0 3.2755 ms/op 2.9291 ms/op 1.12
forkChoice updateHead vc 600000 bc 1200 eq 0 3.5671 ms/op 2.9485 ms/op 1.21
forkChoice updateHead vc 600000 bc 7200 eq 0 4.1576 ms/op 4.5551 ms/op 0.91
forkChoice updateHead vc 600000 bc 64 eq 1000 10.821 ms/op 10.553 ms/op 1.03
forkChoice updateHead vc 600000 bc 64 eq 10000 10.926 ms/op 10.869 ms/op 1.01
forkChoice updateHead vc 600000 bc 64 eq 300000 29.620 ms/op 14.041 ms/op 2.11
computeDeltas 500000 validators 300 proto nodes 5.2811 ms/op 4.3215 ms/op 1.22
computeDeltas 500000 validators 1200 proto nodes 5.1926 ms/op 4.2735 ms/op 1.22
computeDeltas 500000 validators 7200 proto nodes 4.8575 ms/op 4.2366 ms/op 1.15
computeDeltas 750000 validators 300 proto nodes 6.9339 ms/op 6.2576 ms/op 1.11
computeDeltas 750000 validators 1200 proto nodes 6.6420 ms/op 6.1804 ms/op 1.07
computeDeltas 750000 validators 7200 proto nodes 6.2738 ms/op 6.0839 ms/op 1.03
computeDeltas 1400000 validators 300 proto nodes 11.551 ms/op 11.548 ms/op 1.00
computeDeltas 1400000 validators 1200 proto nodes 11.553 ms/op 11.734 ms/op 0.98
computeDeltas 1400000 validators 7200 proto nodes 11.362 ms/op 11.823 ms/op 0.96
computeDeltas 2100000 validators 300 proto nodes 17.209 ms/op 18.392 ms/op 0.94
computeDeltas 2100000 validators 1200 proto nodes 17.628 ms/op 17.685 ms/op 1.00
computeDeltas 2100000 validators 7200 proto nodes 18.519 ms/op 17.385 ms/op 1.07
altair processAttestation - 250000 vs - 7PWei normalcase 3.0689 ms/op 1.8050 ms/op 1.70
altair processAttestation - 250000 vs - 7PWei worstcase 4.2860 ms/op 2.7384 ms/op 1.57
altair processAttestation - setStatus - 1/6 committees join 124.81 us/op 92.770 us/op 1.35
altair processAttestation - setStatus - 1/3 committees join 225.99 us/op 178.05 us/op 1.27
altair processAttestation - setStatus - 1/2 committees join 304.94 us/op 258.65 us/op 1.18
altair processAttestation - setStatus - 2/3 committees join 452.07 us/op 331.85 us/op 1.36
altair processAttestation - setStatus - 4/5 committees join 796.48 us/op 479.90 us/op 1.66
altair processAttestation - setStatus - 100% committees join 1.2950 ms/op 570.28 us/op 2.27
altair processBlock - 250000 vs - 7PWei normalcase 9.4741 ms/op 5.6635 ms/op 1.67
altair processBlock - 250000 vs - 7PWei normalcase hashState 38.146 ms/op 26.008 ms/op 1.47
altair processBlock - 250000 vs - 7PWei worstcase 47.544 ms/op 32.301 ms/op 1.47
altair processBlock - 250000 vs - 7PWei worstcase hashState 94.529 ms/op 68.780 ms/op 1.37
phase0 processBlock - 250000 vs - 7PWei normalcase 4.0437 ms/op 2.1171 ms/op 1.91
phase0 processBlock - 250000 vs - 7PWei worstcase 32.894 ms/op 22.193 ms/op 1.48
altair processEth1Data - 250000 vs - 7PWei normalcase 609.76 us/op 321.13 us/op 1.90
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 12.018 us/op 6.5170 us/op 1.84
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 56.972 us/op 37.189 us/op 1.53
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 18.233 us/op 14.008 us/op 1.30
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 11.517 us/op 5.7120 us/op 2.02
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 233.93 us/op 115.21 us/op 2.03
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.9736 ms/op 1.0469 ms/op 1.89
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.2191 ms/op 1.4455 ms/op 1.54
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.9359 ms/op 1.4337 ms/op 1.35
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 5.1272 ms/op 3.6080 ms/op 1.42
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.6091 ms/op 1.4870 ms/op 1.08
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.7196 ms/op 3.9572 ms/op 1.19
Tree 40 250000 create 412.01 ms/op 221.13 ms/op 1.86
Tree 40 250000 get(125000) 198.18 ns/op 158.63 ns/op 1.25
Tree 40 250000 set(125000) 1.1970 us/op 730.53 ns/op 1.64
Tree 40 250000 toArray() 25.748 ms/op 17.933 ms/op 1.44
Tree 40 250000 iterate all - toArray() + loop 28.524 ms/op 19.692 ms/op 1.45
Tree 40 250000 iterate all - get(i) 89.539 ms/op 61.037 ms/op 1.47
Array 250000 create 5.8066 ms/op 3.5659 ms/op 1.63
Array 250000 clone - spread 4.8671 ms/op 1.5941 ms/op 3.05
Array 250000 get(125000) 0.87600 ns/op 0.42600 ns/op 2.06
Array 250000 set(125000) 0.88600 ns/op 0.45700 ns/op 1.94
Array 250000 iterate all - loop 132.03 us/op 103.77 us/op 1.27
phase0 afterProcessEpoch - 250000 vs - 7PWei 57.457 ms/op 52.970 ms/op 1.08
Array.fill - length 1000000 7.3217 ms/op 3.7225 ms/op 1.97
Array push - length 1000000 31.804 ms/op 13.711 ms/op 2.32
Array.get 0.35469 ns/op 0.28261 ns/op 1.26
Uint8Array.get 0.48235 ns/op 0.44068 ns/op 1.09
phase0 beforeProcessEpoch - 250000 vs - 7PWei 25.689 ms/op 21.340 ms/op 1.20
altair processEpoch - mainnet_e81889 381.84 ms/op 252.73 ms/op 1.51
mainnet_e81889 - altair beforeProcessEpoch 24.154 ms/op 18.629 ms/op 1.30
mainnet_e81889 - altair processJustificationAndFinalization 21.482 us/op 11.746 us/op 1.83
mainnet_e81889 - altair processInactivityUpdates 6.8842 ms/op 5.4569 ms/op 1.26
mainnet_e81889 - altair processRewardsAndPenalties 64.392 ms/op 36.572 ms/op 1.76
mainnet_e81889 - altair processRegistryUpdates 7.0920 us/op 1.7880 us/op 3.97
mainnet_e81889 - altair processSlashings 1.3730 us/op 370.00 ns/op 3.71
mainnet_e81889 - altair processEth1DataReset 1.5550 us/op 413.00 ns/op 3.77
mainnet_e81889 - altair processEffectiveBalanceUpdates 3.1217 ms/op 1.9413 ms/op 1.61
mainnet_e81889 - altair processSlashingsReset 7.6860 us/op 2.7430 us/op 2.80
mainnet_e81889 - altair processRandaoMixesReset 9.7290 us/op 3.3230 us/op 2.93
mainnet_e81889 - altair processHistoricalRootsUpdate 1.2990 us/op 642.00 ns/op 2.02
mainnet_e81889 - altair processParticipationFlagUpdates 6.4730 us/op 2.2870 us/op 2.83
mainnet_e81889 - altair processSyncCommitteeUpdates 1.4000 us/op 456.00 ns/op 3.07
mainnet_e81889 - altair afterProcessEpoch 55.649 ms/op 50.491 ms/op 1.10
capella processEpoch - mainnet_e217614 1.2353 s/op 944.08 ms/op 1.31
mainnet_e217614 - capella beforeProcessEpoch 86.107 ms/op 77.125 ms/op 1.12
mainnet_e217614 - capella processJustificationAndFinalization 24.604 us/op 18.694 us/op 1.32
mainnet_e217614 - capella processInactivityUpdates 21.863 ms/op 17.297 ms/op 1.26
mainnet_e217614 - capella processRewardsAndPenalties 263.25 ms/op 218.29 ms/op 1.21
mainnet_e217614 - capella processRegistryUpdates 26.932 us/op 12.554 us/op 2.15
mainnet_e217614 - capella processSlashings 1.2160 us/op 364.00 ns/op 3.34
mainnet_e217614 - capella processEth1DataReset 1.0310 us/op 338.00 ns/op 3.05
mainnet_e217614 - capella processEffectiveBalanceUpdates 9.4342 ms/op 16.407 ms/op 0.58
mainnet_e217614 - capella processSlashingsReset 11.063 us/op 4.6800 us/op 2.36
mainnet_e217614 - capella processRandaoMixesReset 11.365 us/op 5.0970 us/op 2.23
mainnet_e217614 - capella processHistoricalRootsUpdate 1.3040 us/op 562.00 ns/op 2.32
mainnet_e217614 - capella processParticipationFlagUpdates 5.9380 us/op 2.0540 us/op 2.89
mainnet_e217614 - capella afterProcessEpoch 137.79 ms/op 123.40 ms/op 1.12
phase0 processEpoch - mainnet_e58758 426.82 ms/op 326.59 ms/op 1.31
mainnet_e58758 - phase0 beforeProcessEpoch 117.31 ms/op 73.265 ms/op 1.60
mainnet_e58758 - phase0 processJustificationAndFinalization 24.161 us/op 12.991 us/op 1.86
mainnet_e58758 - phase0 processRewardsAndPenalties 33.840 ms/op 31.651 ms/op 1.07
mainnet_e58758 - phase0 processRegistryUpdates 10.838 us/op 7.9440 us/op 1.36
mainnet_e58758 - phase0 processSlashings 1.0300 us/op 336.00 ns/op 3.07
mainnet_e58758 - phase0 processEth1DataReset 747.00 ns/op 321.00 ns/op 2.33
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.4809 ms/op 1.1927 ms/op 2.08
mainnet_e58758 - phase0 processSlashingsReset 9.7650 us/op 2.9490 us/op 3.31
mainnet_e58758 - phase0 processRandaoMixesReset 13.689 us/op 4.6490 us/op 2.94
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.3010 us/op 319.00 ns/op 4.08
mainnet_e58758 - phase0 processParticipationRecordUpdates 9.7220 us/op 2.8380 us/op 3.43
mainnet_e58758 - phase0 afterProcessEpoch 48.345 ms/op 42.183 ms/op 1.15
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.7203 ms/op 1.4237 ms/op 1.21
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.6533 ms/op 2.5298 ms/op 1.44
altair processInactivityUpdates - 250000 normalcase 23.592 ms/op 15.757 ms/op 1.50
altair processInactivityUpdates - 250000 worstcase 21.473 ms/op 17.911 ms/op 1.20
phase0 processRegistryUpdates - 250000 normalcase 13.978 us/op 10.009 us/op 1.40
phase0 processRegistryUpdates - 250000 badcase_full_deposits 415.84 us/op 300.33 us/op 1.38
phase0 processRegistryUpdates - 250000 worstcase 0.5 137.87 ms/op 123.12 ms/op 1.12
altair processRewardsAndPenalties - 250000 normalcase 54.330 ms/op 39.676 ms/op 1.37
altair processRewardsAndPenalties - 250000 worstcase 35.911 ms/op 40.214 ms/op 0.89
phase0 getAttestationDeltas - 250000 normalcase 12.516 ms/op 8.0457 ms/op 1.56
phase0 getAttestationDeltas - 250000 worstcase 9.7688 ms/op 10.806 ms/op 0.90
phase0 processSlashings - 250000 worstcase 140.95 us/op 100.61 us/op 1.40
altair processSyncCommitteeUpdates - 250000 133.16 ms/op 128.98 ms/op 1.03
BeaconState.hashTreeRoot - No change 241.00 ns/op 233.00 ns/op 1.03
BeaconState.hashTreeRoot - 1 full validator 126.23 us/op 127.78 us/op 0.99
BeaconState.hashTreeRoot - 32 full validator 1.4057 ms/op 1.6373 ms/op 0.86
BeaconState.hashTreeRoot - 512 full validator 18.145 ms/op 10.882 ms/op 1.67
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 214.63 us/op 119.27 us/op 1.80
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.8086 ms/op 1.7031 ms/op 1.65
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 32.105 ms/op 20.344 ms/op 1.58
BeaconState.hashTreeRoot - 1 balances 130.75 us/op 96.939 us/op 1.35
BeaconState.hashTreeRoot - 32 balances 1.0447 ms/op 758.57 us/op 1.38
BeaconState.hashTreeRoot - 512 balances 10.128 ms/op 7.8429 ms/op 1.29
BeaconState.hashTreeRoot - 250000 balances 186.32 ms/op 144.31 ms/op 1.29
aggregationBits - 2048 els - zipIndexesInBitList 42.080 us/op 31.638 us/op 1.33
byteArrayEquals 32 55.300 ns/op 53.696 ns/op 1.03
Buffer.compare 32 18.475 ns/op 17.269 ns/op 1.07
byteArrayEquals 1024 1.6374 us/op 1.5762 us/op 1.04
Buffer.compare 1024 26.897 ns/op 24.709 ns/op 1.09
byteArrayEquals 16384 27.516 us/op 25.047 us/op 1.10
Buffer.compare 16384 275.43 ns/op 246.79 ns/op 1.12
byteArrayEquals 123687377 193.44 ms/op 193.15 ms/op 1.00
Buffer.compare 123687377 7.7928 ms/op 10.717 ms/op 0.73
byteArrayEquals 32 - diff last byte 52.148 ns/op 54.010 ns/op 0.97
Buffer.compare 32 - diff last byte 17.007 ns/op 17.714 ns/op 0.96
byteArrayEquals 1024 - diff last byte 1.5793 us/op 1.6245 us/op 0.97
Buffer.compare 1024 - diff last byte 26.094 ns/op 26.302 ns/op 0.99
byteArrayEquals 16384 - diff last byte 25.251 us/op 25.458 us/op 0.99
Buffer.compare 16384 - diff last byte 211.28 ns/op 210.72 ns/op 1.00
byteArrayEquals 123687377 - diff last byte 194.02 ms/op 194.28 ms/op 1.00
Buffer.compare 123687377 - diff last byte 8.8900 ms/op 8.8325 ms/op 1.01
byteArrayEquals 32 - random bytes 5.3020 ns/op 5.3510 ns/op 0.99
Buffer.compare 32 - random bytes 17.964 ns/op 17.947 ns/op 1.00
byteArrayEquals 1024 - random bytes 5.2570 ns/op 5.3720 ns/op 0.98
Buffer.compare 1024 - random bytes 17.257 ns/op 17.814 ns/op 0.97
byteArrayEquals 16384 - random bytes 5.2650 ns/op 5.5710 ns/op 0.95
Buffer.compare 16384 - random bytes 17.676 ns/op 17.810 ns/op 0.99
byteArrayEquals 123687377 - random bytes 6.8000 ns/op 6.6000 ns/op 1.03
Buffer.compare 123687377 - random bytes 20.230 ns/op 18.990 ns/op 1.07
regular array get 100000 times 39.450 us/op 33.477 us/op 1.18
wrappedArray get 100000 times 33.911 us/op 37.264 us/op 0.91
arrayWithProxy get 100000 times 15.284 ms/op 14.950 ms/op 1.02
ssz.Root.equals 46.298 ns/op 47.652 ns/op 0.97
byteArrayEquals 46.198 ns/op 46.329 ns/op 1.00
Buffer.compare 10.863 ns/op 10.922 ns/op 0.99
processSlot - 1 slots 15.404 us/op 12.069 us/op 1.28
processSlot - 32 slots 3.8121 ms/op 2.4598 ms/op 1.55
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 39.517 ms/op 36.189 ms/op 1.09
getCommitteeAssignments - req 1 vs - 250000 vc 2.1762 ms/op 2.1553 ms/op 1.01
getCommitteeAssignments - req 100 vs - 250000 vc 4.1583 ms/op 4.1831 ms/op 0.99
getCommitteeAssignments - req 1000 vs - 250000 vc 4.5827 ms/op 4.5957 ms/op 1.00
findModifiedValidators - 10000 modified validators 288.52 ms/op 248.73 ms/op 1.16
findModifiedValidators - 1000 modified validators 240.10 ms/op 170.03 ms/op 1.41
findModifiedValidators - 100 modified validators 256.53 ms/op 149.44 ms/op 1.72
findModifiedValidators - 10 modified validators 233.80 ms/op 158.32 ms/op 1.48
findModifiedValidators - 1 modified validators 173.56 ms/op 149.81 ms/op 1.16
findModifiedValidators - no difference 222.08 ms/op 160.78 ms/op 1.38
compare ViewDUs 3.6466 s/op 3.1237 s/op 1.17
compare each validator Uint8Array 1.7139 s/op 1.0491 s/op 1.63
compare ViewDU to Uint8Array 1.2705 s/op 1.0016 s/op 1.27
migrate state 1000000 validators, 24 modified, 0 new 821.67 ms/op 670.70 ms/op 1.23
migrate state 1000000 validators, 1700 modified, 1000 new 1.1581 s/op 918.65 ms/op 1.26
migrate state 1000000 validators, 3400 modified, 2000 new 1.2662 s/op 1.0805 s/op 1.17
migrate state 1500000 validators, 24 modified, 0 new 809.63 ms/op 753.09 ms/op 1.08
migrate state 1500000 validators, 1700 modified, 1000 new 987.95 ms/op 954.44 ms/op 1.04
migrate state 1500000 validators, 3400 modified, 2000 new 1.1825 s/op 1.1668 s/op 1.01
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.5300 ns/op 4.3100 ns/op 1.05
state getBlockRootAtSlot - 250000 vs - 7PWei 913.28 ns/op 919.62 ns/op 0.99
computeProposers - vc 250000 8.4704 ms/op 7.2291 ms/op 1.17
computeEpochShuffling - vc 250000 41.748 ms/op 41.369 ms/op 1.01
getNextSyncCommittee - vc 250000 132.00 ms/op 119.99 ms/op 1.10
computeSigningRoot for AttestationData 21.701 us/op 17.726 us/op 1.22
hash AttestationData serialized data then Buffer.toString(base64) 1.5859 us/op 1.5496 us/op 1.02
toHexString serialized data 885.08 ns/op 872.66 ns/op 1.01
Buffer.toString(base64) 190.91 ns/op 181.77 ns/op 1.05
nodejs block root to RootHex using toHex 162.23 ns/op 158.34 ns/op 1.02
nodejs block root to RootHex using toRootHex 96.273 ns/op 96.462 ns/op 1.00
browser block root to RootHex using the deprecated toHexString 231.18 ns/op 223.86 ns/op 1.03
browser block root to RootHex using toHex 186.09 ns/op 179.14 ns/op 1.04
browser block root to RootHex using toRootHex 170.40 ns/op 161.92 ns/op 1.05

by benchmarkbot/action

nflaig
nflaig approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nazarhussain nazarhussain merged commit 245d63e into unstable Oct 16, 2024
20 checks passed
@nazarhussain nazarhussain deleted the nh/clean-biome-overrides branch October 16, 2024 12:44
philknows pushed a commit that referenced this pull request Oct 18, 2024
@nazarhussain @philknows
chore: cleanup overrides for the biomejs configuration (#7162)
8d1f7b3 
* Clean overrides for unused variables

* Fix the naming conventions

* Add comments in the biome

* Fix code feedback
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.23.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

Assignees

@nazarhussain nazarhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nazarhussain @wemeetagain @nflaig