-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add standard endpoint to retrieve fork choice context #7127
Conversation
data: ForkChoiceResponseType, | ||
meta: EmptyMetaCodec, | ||
onlySupport: WireFormat.json, | ||
transform: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per spec it's not wrapped in data
container... it's too late to change it now though 😢
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7127 +/- ##
============================================
+ Coverage 49.04% 49.09% +0.04%
============================================
Files 596 596
Lines 39743 39782 +39
Branches 2065 2059 -6
============================================
+ Hits 19493 19531 +38
- Misses 20209 20210 +1
Partials 41 41 |
Performance Report✔️ no performance regression detected Full benchmark results
|
🎉 This PR is included in v1.23.0 🎉 |
Motivation
Description
Add standardized endpoint from beacon-api spec to retrieve fork choice context
Closes #5700