Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1 attestation apis #7412

Open
nflaig opened this issue Jan 30, 2025 · 3 comments
Open

Remove v1 attestation apis #7412

nflaig opened this issue Jan 30, 2025 · 3 comments
Labels
spec-fulu Issues targeting the Fulu spec version

Comments

@nflaig
Copy link
Member

nflaig commented Jan 30, 2025

The v1 attestation apis become effectively useless after electra hard fork since they only support the phase0 format. The v2 apis are fork-aware and backward compatible so it might be fine to just remove v1 soon after the hard fork but we likely need to wait until fulu for them to be removed from the beacon-api spec.

@nflaig nflaig added the spec-electra 🦒 Issues targeting the Electra spec version label Jan 30, 2025
@philknows
Copy link
Member

Same with this, could probably tag as Fulu as we can remove it then.

@philknows philknows added spec-fulu Issues targeting the Fulu spec version and removed spec-electra 🦒 Issues targeting the Electra spec version labels Feb 3, 2025
@nflaig
Copy link
Member Author

nflaig commented Feb 3, 2025

Same with this, could probably tag as Fulu as we can remove it then.

I am not sure how aggressive we wanna be at removing those, technically could do it in our next release right after Electra but might keep them around for another fork

@philknows
Copy link
Member

We don't need to be aggressive with it especially if we have more important matters to put our time to. But thanks for creating the issue to track removal though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-fulu Issues targeting the Fulu spec version
Projects
None yet
Development

No branches or pull requests

2 participants