Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keymanager 204 (no content) responses return empty json body #6110

Closed
nflaig opened this issue Nov 15, 2023 · 1 comment · Fixed by #6749
Closed

Keymanager 204 (no content) responses return empty json body #6110

nflaig opened this issue Nov 15, 2023 · 1 comment · Fixed by #6749
Labels
meta-bug Issues that identify a bug and require a fix.

Comments

@nflaig
Copy link
Member

nflaig commented Nov 15, 2023

Describe the bug

Some keymanager APIs are not spec compliant due to the fact that we return a empty json body even though the HTTP status code is 204 (no content). The content length header is also invalid which might cause issues on the client sending the request (content-length: 2).

This is due to the fact that Lodestar always adds an empty response body even if there is no return type

Expected behavior

Lodestar should not return an empty json body in 204 responses.

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

v1.12.0

@nflaig nflaig added the meta-bug Issues that identify a bug and require a fix. label Nov 15, 2023
@nflaig
Copy link
Member Author

nflaig commented Dec 5, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant