Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keymanager API: decrypt keystores in a thread pool #5438

Closed
nflaig opened this issue Apr 30, 2023 · 1 comment · Fixed by #5624
Closed

Keymanager API: decrypt keystores in a thread pool #5438

nflaig opened this issue Apr 30, 2023 · 1 comment · Fixed by #5624
Assignees
Labels
meta-feature-request Issues to track feature requests. prio-high Resolve issues as soon as possible. scope-ux Issues for CLI UX or general consumer UX.
Milestone

Comments

@nflaig
Copy link
Member

nflaig commented Apr 30, 2023

Similar to #5357, when importing keystores through the keymanager API we should decrypt in a thread pool to reduce the time it takes to import a lot of keys.

  • decrypt in a thread pool (in parallel)
  • limit with a queue to prevent killing the vc process

Based on existing tooling and use cases, there seems to be less of an requirement to import a lot of keys via API. Most operators with a lot of keys use --importKeystores or pre-import keys via validator import. Other solutions that use keymanager API often call import per keystore separately as there is also the max body limit restriction enforced by the API which needs to be overriden separately by setting --keymanager.bodyLimit.

@nflaig nflaig added scope-ux Issues for CLI UX or general consumer UX. meta-feature-request Issues to track feature requests. labels Apr 30, 2023
@philknows philknows added this to the v1.9.0 milestone May 9, 2023
@nflaig
Copy link
Member Author

nflaig commented May 10, 2023

Might fix issues faced by operators that import a lot of keys in a single request as it offloads keystore decryption to a worker thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-feature-request Issues to track feature requests. prio-high Resolve issues as soon as possible. scope-ux Issues for CLI UX or general consumer UX.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants