Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify spec runner's fork_choice.test.ts to include testcases for on_merge_block scenario #3986

Closed
g11tech opened this issue May 7, 2022 · 0 comments · Fixed by #3984
Closed

Modify spec runner's fork_choice.test.ts to include testcases for on_merge_block scenario #3986

g11tech opened this issue May 7, 2022 · 0 comments · Fixed by #3984
Assignees
@g11tech

Comments

@g11tech
Copy link
Contributor

g11tech commented May 7, 2022

Seems like the tests for merge block transitions have been included in the specs, but our fork_choice.test.ts doesn't yet address them.

Modify and make the spec runner run these tests successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g11tech g11tech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the terminal validations of the merge block ChainSafe/lodestar
1 participant
@g11tech