fix: close peer manager before sending goodbye to all peers

ChainSafe · Jul 11, 2023 · 66d6846 · 66d6846
1 parent 85ff3cf
commit 66d6846
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/beacon-node/src/network/core/networkCore.ts b/packages/beacon-node/src/network/core/networkCore.ts
@@ -249,11 +249,13 @@ export class NetworkCore implements INetworkCore {
 
     this.clock.off(ClockEvent.epoch, this.onEpoch);
 
+    // Must close peer manager before disconnecting peers to
+    // prevent registering newly discovered peers afterwards
+    await this.peerManager.close();
+    this.logger.debug("network peerManager closed");
     // Must goodbye and disconnect before stopping libp2p
     await this.peerManager.goodbyeAndDisconnectAllPeers();
     this.logger.debug("network sent goodbye to all peers");
-    await this.peerManager.close();
-    this.logger.debug("network peerManager closed");
     await this.gossip.stop();
     this.logger.debug("network gossip closed");
     await this.reqResp.stop();