Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish at least mesh_n peers #493

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Mar 27, 2024

Motivation

  • Lodestar may want to set floodPublish as false in the future

Description

  • In that case we want to publish at least mesh_n peers

see ChainSafe/lodestar#6596 (comment)

@twoeths twoeths marked this pull request as ready for review March 27, 2024 09:21
@twoeths twoeths requested a review from a team as a code owner March 27, 2024 09:21
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 78.68%. Comparing base (ff620fd) to head (14a6c32).

❗ Current head 14a6c32 differs from pull request most recent head e43f074. Consider uploading reports for the commit e43f074 to get more accurate results

Files Patch % Lines
src/index.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   78.79%   78.68%   -0.12%     
==========================================
  Files          46       46              
  Lines       11007    11019      +12     
  Branches     1077     1075       -2     
==========================================
- Hits         8673     8670       -3     
- Misses       2334     2349      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twoeths twoeths merged commit bc3906f into master Apr 19, 2024
9 checks passed
@twoeths twoeths deleted the tuyen/publish_at_least_mesh_n_peers branch April 19, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants