chore: track backoff time for connected peers #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
reviewed
Jun 28, 2023
src/index.ts
Outdated
| for (const backoff of this.backoff.values()) { | ||
| backoffSize += backoff.size | ||
| for (const [peer, expiredMs] of backoff.entries()) { | ||
| if (this.peers.has(peer)) { | ||
| metrics.connectedPeersBackoffSec.observe((expiredMs - now) / 1000) |
There was a problem hiding this comment.
Reset the histogram values above to have a read of current status. Similar to Lodestar's gossipsub metrics. Also record only positive numbers or histograms render poorly Math.max(0, expiredMs - now) / 1000
dapplion
reviewed
Jun 28, 2023
src/metrics.ts
Outdated
| connectedPeersBackoffSec: register.histogram({ | ||
| name: 'gossipsub_connected_peers_backoff_seconds', | ||
| help: 'Backoff time in seconds', | ||
| buckets: [1, 2, 4, 8, 16, 32, 64, 128, 256] |
There was a problem hiding this comment.
Values could align more with spec parameters such that
[1,2,4,10,20,60,120]
also do add a comment like:
Using 1 seconds as minimum as that's close to the heartbeat duration, no need for more resolution.
As per spec, backoff times are 10 seconds for UnsubscribeBackoff and 60 seconds for PruneBackoff.
Higher values of 60 seconds should not occur, but we add 120 seconds just in case
https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#overview-of-new-parameters
twoeths
force-pushed
the
tuyen/backoff_time_metric
branch
from
291e4c2
to
ff794b4
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #445 +/- ##
==========================================
- Coverage 82.51% 82.39% -0.13%
==========================================
Files 48 48
Lines 11966 11984 +18
Branches 1279 1279
==========================================
Hits 9874 9874
- Misses 2092 2110 +18
☔ View full report in Codecov by Sentry. |
wemeetagain
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Closes Track backoff times in connected peers #442