-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add rpc error metrics #412
Conversation
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 83.31% 83.04% -0.27%
==========================================
Files 48 48
Lines 11800 11858 +58
Branches 1271 1279 +8
==========================================
+ Hits 9831 9848 +17
- Misses 1969 2010 +41
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/index.ts
Outdated
let graft = 0 | ||
let prune = 0 | ||
if (rpc.control) { | ||
ihave = rpc.control.ihave ? rpc.control.ihave.length : 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to re-assign
ihave = rpc.control.ihave ? rpc.control.ihave.length : 0 | |
if (rpc.control.ihave) ihave = rpc.control.ihave.length |
Motivation
Description
part of #411
It shows that we really have rpc errors when deploying this branch to a lodestar node