fix: sync leave() function #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
reviewed
Nov 30, 2022
src/index.ts
Outdated
| @@ -1843,15 +1841,17 @@ export class GossipSub extends EventEmitter<GossipsubEvents> implements PubSub<G | |||
| this.metrics?.onLeave(topic) | |||
|
|
|||
| // Send PRUNE to mesh peers | |||
| this.mesh.delete(topic) | |||
There was a problem hiding this comment.
this line should be kept where it was. Or at least below L1845
wemeetagain
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
unsubscribe()andsubscribe()the same topic immediately, see v1.2.1: Low mesh peers due to p7 lodestar#4818 (comment)leave()function is sync instead of async as in masterDescription
leave()function as syncpart of ChainSafe/lodestar#4818