-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sendRpc in a for loop #347
Conversation
"feat: fix"? 😂 |
aa61f42
to
5afb3ca
Compare
Codecov ReportBase: 79.98% // Head: 79.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
==========================================
- Coverage 79.98% 79.97% -0.01%
==========================================
Files 44 44
Lines 11226 11223 -3
Branches 1018 1018
==========================================
- Hits 8979 8976 -3
Misses 2247 2247
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed createGossipRpc
function completely
Description
sendRpc()
function expect new rpc param every time we call it because it modifies that param. If we call it in a for loop, the control part could be accumulated from prior loops.forward
andpublish
scenario