Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to it-length-prefixed 8.0.2 #312

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Aug 3, 2022

Motivation

  • it-length-prefixed yields no-copy data, it should help improve performance

Description

  • Migrate to it-length-prefixed 8.0.2
  • Remove the BufferList assumption since it-length-prefixed yields Uint8ArrayList consistently

@twoeths twoeths requested a review from a team as a code owner August 3, 2022 05:50
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #312 (52b5992) into master (f6ab12d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   79.83%   79.81%   -0.03%     
==========================================
  Files          44       44              
  Lines       11044    11033      -11     
  Branches     1014     1013       -1     
==========================================
- Hits         8817     8806      -11     
  Misses       2227     2227              
Impacted Files Coverage Δ
src/index.ts 70.70% <100.00%> (-0.13%) ⬇️
src/stream.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ab12d...52b5992. Read the comment docs.

@twoeths twoeths force-pushed the tuyen/it-length-prefix-8.0.2 branch from d0ad868 to 52b5992 Compare August 3, 2022 06:07
@twoeths twoeths changed the title Migrate to it-length-prefixed 8.0.2 chore: migrate to it-length-prefixed 8.0.2 Aug 3, 2022
@wemeetagain wemeetagain merged commit 90c2a0b into master Aug 3, 2022
@wemeetagain wemeetagain deleted the tuyen/it-length-prefix-8.0.2 branch August 3, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants