Move fil_actor_interface to forest shim #5001
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-shashank
force-pushed
the
shashank/move-actor-interface
branch
from
08ae10f
to
adeb5ae
Compare
hanabi1224
reviewed
Nov 27, 2024
| @@ -121,6 +122,7 @@ lru = "0.12" | |||
| memmap2 = "0.9" | |||
| memory-stats = "1" | |||
| multiaddr = "0.18" | |||
| multihash = { version = "0.18", features = ["identity"] } | |||
There was a problem hiding this comment.
multihash is re-exported from cid and can be accessed by cid::multihash, let's not add it to the deps
hanabi1224
reviewed
Nov 27, 2024
| @@ -10,6 +10,7 @@ use crate::chain_sync::collect_errs; | |||
| use crate::metrics::HistogramTimerExt; | |||
| use crate::networks::{ChainConfig, Height}; | |||
| use crate::shim::actors::PowerActorStateLoad as _; | |||
| use crate::shim::actors_interface::power; | |||
There was a problem hiding this comment.
_iterface looks redundant when it's under shim, what do you think?
There was a problem hiding this comment.
It'll require a bit of reorg, but makes total sense. One less "abstraction" will hopefully lead to flattening the learning curve a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
fil_actor_interfacefrom fil-actor-states toshim/actors_interfaceReference issue to close (if applicable)
Closes #4875
Other information and links
Change checklist