Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP 34 - Fix pre-commit deposit independent of sector content #1903

Closed
4 tasks done
lemmih opened this issue Sep 13, 2022 · 1 comment
Closed
4 tasks done

FIP 34 - Fix pre-commit deposit independent of sector content #1903

lemmih opened this issue Sep 13, 2022 · 1 comment
Assignees

Comments

@lemmih
Copy link
Contributor

lemmih commented Sep 13, 2022

Issue summary

Checklist:

  • Are there any changes to the actor data structures that we need to be aware of?
  • Are there any changes to the network protocol?
  • Are there any changes to node behavior (eg. changes in block validation criteria, random number generation, etc)?
  • Are there any new magic numbers?

Other information and links

https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0034.md

@lemmih lemmih added this to the Forest 🌲 in Beta milestone Sep 13, 2022
@LesnyRumcajs LesnyRumcajs self-assigned this Sep 19, 2022
@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Sep 21, 2022

Data structures change

SectorPreCommitOnChainInfo should be changed to what builtin-actors expose. Same applies to SectorPreCommitInfo. We do some serde tricks so it may not be possible to import it, most likely we'll just need adapt the changes in our implementation.

Logical flow
It should be self-contained in builtin-actors.

Related PR: filecoin-project/builtin-actors#484

⚠️ Tests ⚠️
Those structs are used only in our RPC API which is not covered by tests. It would be great to at least test that it works manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants