Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Built in xvfb support #197

Closed
mpetrunic opened this issue Nov 29, 2022 · 2 comments
Closed

Built in xvfb support #197

mpetrunic opened this issue Nov 29, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@mpetrunic
Copy link
Member

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Currently, in github actions, we need to run tests with xvfb-run --auto-servernum yarn test
which is unusual to inexperienced devs.

Describe the solution you'd like
A clear and concise description of what you want to happen.
I would propose that we add additional option gui: boolean which would be true by default and utilize https://www.npmjs.com/package/@cypress/xvfb or https://www.npmjs.com/package/xvfb to achieve this in code

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

cc @BeroBurny

@mpetrunic mpetrunic added the enhancement New feature or request label Nov 29, 2022
@mpetrunic mpetrunic moved this to New Issues in Dappeteer Nov 29, 2022
@mpetrunic mpetrunic moved this from New Issues to Backlog in Dappeteer Nov 29, 2022
@Lykhoyda
Copy link
Contributor

@mpetrunic probably it's not relevant anymore as we are running headless mode in chrome directly

@mpetrunic
Copy link
Member Author

Yup

@github-project-automation github-project-automation bot moved this from Backlog to Done/Closed in Dappeteer Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done/Closed
Development

No branches or pull requests

2 participants