Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Replace addNetwork/addToken/switchNetwork methods #181

Closed
mpetrunic opened this issue Nov 11, 2022 · 2 comments
Closed

Replace addNetwork/addToken/switchNetwork methods #181

mpetrunic opened this issue Nov 11, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request P0 Critical. Tacked by core team

Comments

@mpetrunic
Copy link
Member

Is your feature request related to a problem? Please describe.

Those methods are relicts of history where dapps couldn't send rpc method calls to force metamask to do this. Flow is now different and we should adapt dappeteer to have methods to accept/reject prompts for adding network, token or switching network.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Replace methods (breaking change), add buttons into our test dapp to add network, switch network and add token.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@mpetrunic mpetrunic added feature P0 Critical. Tacked by core team and removed feature labels Nov 11, 2022
@mpetrunic mpetrunic moved this to New Issues in Dappeteer Nov 11, 2022
@mpetrunic mpetrunic moved this from New Issues to Backlog in Dappeteer Nov 11, 2022
@danforbes danforbes moved this from Backlog to Review in Dappeteer Nov 15, 2022
@Tbaut
Copy link
Contributor

Tbaut commented Nov 30, 2022

This has been fixed in #189 but I'll keep it open to update the documentation.

@Tbaut Tbaut self-assigned this Nov 30, 2022
@Tbaut
Copy link
Contributor

Tbaut commented Dec 1, 2022

There's actually much more than this. Making a dedicated issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request P0 Critical. Tacked by core team
Projects
Status: Done/Closed
Development

No branches or pull requests

2 participants