Fixed cesiumGeometryToGltfPrimitive does not generate unique accessor names #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
reviewed
Sep 27, 2017
specs/lib/generateNormalsSpec.js
Outdated
| var byteLengthBefore = 432; | ||
| generateNormals(gltf); | ||
|
|
||
| console.log(gltf.meshes); |
|
Update CHANGES.md |
|
There is an eslint error: |
… names Added spec in geometryNormals so that when smoothNormals are generated with mesh with 2 primitives, this does not generate duplicate accessors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added spec in geometryNormals so that when smoothNormals are generated
with mesh with 2 primitives, this does not generate duplicate accessors.