Uint16 check #243
Merged
Uint16 check #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @likangning93! @lilleyse can you please review? Also note that this will be a non-issue with glTF 2.0, CC @lasalvavida, and we'll want to have fewer primitives so we have better batching and rendering performance. |
|
@tfili Does this PR work for your use case? |
|
The code and tests look good to me. |
Yep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #230.
combinePrimitivesnow checks if a group of primitives to be concatenated can be concatenated without overflowinguint16(oruint32, although a primitive that big scares me), and if not, it splits the group into two or more groups.I got all excited at first thinking this was some kind of knapsack problem, but then I found out it's kind of more like the bin packing problem but possibly more complex. I tried adapting the first fit decreasing strategy, and under testing in a separate project it seems the implementation at least produces 'correct' results.