Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uniform variables error after updating model from gltf v1.0 to gltf v2.0 #488

Closed
liukangkanglkk99 opened this issue Jul 10, 2019 · 3 comments · Fixed by #490
Closed

uniform variables error after updating model from gltf v1.0 to gltf v2.0 #488

liukangkanglkk99 opened this issue Jul 10, 2019 · 3 comments · Fixed by #490

Comments

@liukangkanglkk99
Copy link

I am trying to update model from gltf v1.0 to gltf v2.0.
The following may occur in a gltf file:
"techniques":{ "a":{ "uniforms":{ "u_tex":"tex", "u_tex2":"bakingTex" } }, "b":{ "uniforms":{ "u_tex":"bakingTex" } } }
But in the function moveTechniquesToExtension(gltf) of moveTechniquesToExtension.js,
the mappedUniforms variable is finally recorded as bakingTex -> u_tex and bakingTex -> u_tex2 information is missing.
This leads to errors in later use of uniform u_tex2.

@lilleyse
Copy link
Contributor

@liukangkanglkk99 Thanks for all the details, it should be quick for us to track this down. If you are able to share the glTF that would be helpful too.

@lilleyse
Copy link
Contributor

@liukangkanglkk99 I opened a fix here: #490.

Would you mind trying it out with your gltf?

@liukangkanglkk99
Copy link
Author

With pleasure. I tested this and it does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants