Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draco option having no effect #420

Closed
donmccurdy opened this issue Sep 5, 2018 · 2 comments
Closed

Draco option having no effect #420

donmccurdy opened this issue Sep 5, 2018 · 2 comments

Comments

@donmccurdy
Copy link

donmccurdy commented Sep 5, 2018

Using gltf-pipeline 2.0.0, and running:

gltf-pipeline -i chr_knight.gltf -o chr_knight_draco.gltf -d -s

No errors are printed, and the output file is valid, but output does not use the Draco extension. Original file (chr_knight.gltf) and output (chr_knight_draco.gltf) attached:

chr_knight.zip

@lilleyse
Copy link
Contributor

lilleyse commented Sep 5, 2018

Stepping through the code it looks like this is because the gltf doesn't have indices and compressDracoMeshes returns early if that's the case. This could be fixed by generating the indices on the fly and passing those through to AddFacesToMesh.

@donmccurdy
Copy link
Author

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants