Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loadGltfUris can run out of file handles #282

Closed
likangning93 opened this issue May 16, 2017 · 1 comment
Closed

loadGltfUris can run out of file handles #282

likangning93 opened this issue May 16, 2017 · 1 comment
Assignees
@likangning93

Comments

@likangning93
Copy link
Contributor

loadGltfUris currently runs out of file handles for models that reference lots of external resources. I have a model that references over 9000 images, and it fails with:

Unhandled rejection Error: EMFILE: too many open files
@likangning93 likangning93 self-assigned this May 16, 2017
@likangning93
Copy link
Contributor Author

Hmm. looks like this is because loadGltfUris uses fs instead of fs-extra. fs-extra under the hood wraps graceful-fs, which avoids EMFILE exceptions by queuing file requests or something.

@likangning93 likangning93 mentioned this issue May 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@likangning93 likangning93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@likangning93