Fixes #12036 - Types for SceneTransforms functions #12048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @ggetz! ✅ We can confirm we have a CLA on file for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue number and link
Fixes #12036
Testing plan
Fixes types for new
Scene.worldTofunctions added in #12000, and the deprecated functions they were renamed from.I have not mentioned this in
CHANGES.mdbecause the functions are newly added or deprecated for this upcoming release.Author checklist
CONTRIBUTORS.mdI have updatedI have not mentioned this inCHANGES.mdwith a short summary of my changeCHANGES.mdbecause the functions are newly added or deprecated for this upcoming release.I have added or updated unit tests to ensure consistent code coverage