Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KML export Sandcastle example #7964

Closed
OmarShehata opened this issue Jun 25, 2019 · 5 comments · Fixed by #7970
Closed

Add KML export Sandcastle example #7964

OmarShehata opened this issue Jun 25, 2019 · 5 comments · Fixed by #7970
Labels
category - sandcastle good first issue An opportunity for first time contributors

Comments

@OmarShehata
Copy link
Contributor

The PR #7921 adds a function to export an EntityCollection in Cesium as KML/KMZ document. There's an example in the doc, but it would be nice to have a full code example that includes the required blob downloading as well. See Fili's code snippet here: #7921 (comment)

It would be cool to use one of these CZML's as a source: https://cesiumjs.org/Cesium/Apps/Sandcastle/index.html?src=CZML.html

Or the extruded GeoJSONs here, so the example shows you how to import a GeoJSON, modify it, then export it:

https://cesiumjs.org/Cesium/Apps/Sandcastle/index.html?src=GeoJSON%20and%20TopoJSON.html

Would also be nice to show how to use the modelCallback to handle rewriting the model URLs. This would be a great first contribution I think!

@OmarShehata OmarShehata added good first issue An opportunity for first time contributors category - sandcastle labels Jun 25, 2019
@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 27, 2019

@tfili @OmarShehata why didn't #7921 include a Sandcastle example? We usually would not merge a new feature without one.

@tfili
Copy link
Contributor

tfili commented Jun 27, 2019

I thought it was a little weird to have a Sandcastle example that just downloads a file that you then need another piece of desktop software to open. I opted for the example in the doc and others seemed to agree. I didn't realize this was going to be a TODO or I would have spent the 10 minutes doing it since the code was already written.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 27, 2019

The KML can be dragged and dropped back into Cesium, right? What other software does it need? To make the feature discoverable seems like we should have went with a Sandcastle example, right? I get that there are limitations, but that is fine if they are documented.

@OmarShehata
Copy link
Contributor Author

I did think a Sandcastle example would be useful, especially to show the download code + rewriting model URLs which may not be obvious. I merged without waiting on that because I figured we could add a fuller example than the one in the doc later, so that was my bad.

@tfili
Copy link
Contributor

tfili commented Jun 27, 2019

Add one here: #7970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - sandcastle good first issue An opportunity for first time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants