Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch datasources to use polylines on terrain #6700

Closed
likangning93 opened this issue Jun 18, 2018 · 6 comments
Closed

Switch datasources to use polylines on terrain #6700

likangning93 opened this issue Jun 18, 2018 · 6 comments

Comments

@likangning93
Copy link
Contributor

At least KMLDataSource is using corridors for polylines clamped to terrain, but now we can use polylines when available.

What other datasources can be updated?

@hpinkos
Copy link
Contributor

hpinkos commented Jun 19, 2018

@likangning93 GeoJsonDataSource takes a clampToGround argument and is currently using a corridor.

@mramato
Copy link
Contributor

mramato commented Jun 19, 2018

These should be be trivial changes, so it would be nice to have them in the next release.

@likangning93
Copy link
Contributor Author

Does this include adding clampToGround to Czml polylines?

@mramato
Copy link
Contributor

mramato commented Jun 19, 2018

Does this include adding clampToGround to Czml polylines?

Yes, does the entity API default to true or false?

@likangning93
Copy link
Contributor Author

It defaults to false. I'm not sure about what else needs to be edited though in terms of CZML documentation/wiki stuff.

@mramato
Copy link
Contributor

mramato commented Jun 19, 2018

@likangning93 the czml-writer repository is where all of that stuff gets handled. CzmlDataSource itself will likely be a one line change. You can work with @shunter to get the property added to the spec.

Glad to hear it defaults to false, since that makes it a non-breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants