Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EllipsoidTerrainProvider with WebMercatorTilingScheme #4610

Closed
pasu opened this issue Nov 5, 2016 · 4 comments
Closed

EllipsoidTerrainProvider with WebMercatorTilingScheme #4610

pasu opened this issue Nov 5, 2016 · 4 comments

Comments

@pasu
Copy link
Contributor

pasu commented Nov 5, 2016

Hi, I think in some situations, especially when we needn't terrain data and mostly the imageryProvider is WebMercatorTilingScheme mode
, it is better to set EllipsoidTerrainProvider tilingScheme as WebMercatorTilingScheme because of high performance and high texture quality.
So, how about it:
ImageryLayer.prototype._reprojectTexture = function(frameState, imagery,terrainTilingScheme)

we add the terrainTilingScheme as a parameter, then we can judge whether to reprojectTexture:

var bBothWebMercatorTilingScheme = (this._imageryProvider.tilingScheme instanceof WebMercatorTilingScheme) && (terrainTilingScheme instanceof WebMercatorTilingScheme);

of couse, I think it is ok that ignoring this situation that EllipsoidTerrainProvider is WebMercatorTilingScheme while imageryProvider is GeographicTilingScheme.

here is my example for this test:
https://github.com/pasu/ExamplesforCesium/blob/master/globeTerrain.html

1

@pasu
Copy link
Contributor Author

pasu commented Nov 7, 2016

I hope somebody can give me a response,
Maybe my idea is not suitable or this situation is rare, so I can get it.
thanks @hpinkos :)

@hpinkos
Copy link
Contributor

hpinkos commented Nov 7, 2016

Sorry I missed this @pasu
This isn't an area of the code I'm very familiar with, @pjcozzi @kring do you have some feedback?

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 10, 2016

@kring is the best person to advise here. There was this recent change: #4339.

@pasu
Copy link
Contributor Author

pasu commented Nov 11, 2016

@pjcozzi I got it from the latest version, it is a smart and general solution for this issue. The comparison and analysis are clear.So happy for this improvement:)

@pasu pasu closed this as completed Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants