Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadows property to Cesium3DTileset #4344

Closed
lilleyse opened this issue Sep 19, 2016 · 7 comments
Closed

Add shadows property to Cesium3DTileset #4344

lilleyse opened this issue Sep 19, 2016 · 7 comments
Labels
good first issue An opportunity for first time contributors

Comments

@lilleyse
Copy link
Contributor

For #3241

Similar to #4341, we should support a shadows property inside Cesium3DTileset, Batched3DModel3DTileContent, and Instanced3DModel3DTileContent. PointCloud3DTileContent is more involved so that should be held off for now.

@sumitshyamsukha Let's work on this one tomorrow.

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 20, 2016

This is for per-feature shadows, right? Although I was the one who suggested this, I would hold off until we have enough interest since this comes with a high memory overhead. I would not use this as a beginner 3D Tiles issue. Please check the roadmap for others and let me know if you need input.

@lilleyse
Copy link
Contributor Author

No this is for the entire tileset.

@lilleyse lilleyse added the good first issue An opportunity for first time contributors label Sep 20, 2016
@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 20, 2016

Ah, +1 from me.

@lilleyse
Copy link
Contributor Author

@sumitshyamsukha #4348 is merged so you should be able to finish your PR when you pull the latest 3d-tiles changes. One more thing to address is being able to set the shadows dynamically rather than just at creation time. To do that, in Batched3DModel3DTileContent.update you can set the model's shadows to equal the tileset's shadows. In Instanced3DModel3DTileContent.update you can set the ModelInstanceCollection's shadows to the tileset's shadows.

@rammy4real
Copy link

hello lilleyse . good day. hope you are doing great sir. i would love to contribute to this. just to let you that i am a starterwith the following knowledge level
html: intermediate
css:intermediate
javascript: basic/beginner
java: basic/beginner
really do love to be part of your team. I promise to give my best and my all .
thank you sir.
[email protected]

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 10, 2016

@lilleyse OK to close this given #4386?

@rammy4real thanks for your interest in contributing to Cesium. A great place to start is the Contributor's Guide.

@lilleyse
Copy link
Contributor Author

@lilleyse OK to close this given #4386?

Yup, closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An opportunity for first time contributors
Projects
None yet
Development

No branches or pull requests

3 participants