-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround Safari 9 WebGL bug #2989
Comments
Should be fixed in https://bugs.webkit.org/show_bug.cgi?id=148449 but doesn't work yet in WebKit r189243 (02 September 2015). |
Still broken in r189485 (September 8th). If iOS 9 does get released tomorrow, I'm assuming Cesium will be broken. |
iOS 9 will be released on September 16 |
@lilleyse can you do this soon? Unfortunately, we're going to need this workaround. I think the best approach is to introduce a new static class like |
@pjcozzi should we make an announcement on the mailing list ahead of time? No need to be too negative on Safari, but just mention that it will break existing Cesium apps and people shouldn't upgrade iOS or Safari if they need Cesium until we release a workaround (or Apple releases a fix). |
Yes I can start working on this today. |
There are many areas that already hard code constants, like https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Renderer/BufferUsage.js#L11-L14 Should I modify all of these to use the new constants class as well? |
Yes, those are very old...before I even knew of
Yes, go ahead. |
Not for 1.13 today.
Discussion: https://twitter.com/pjcozzi/status/638390320619761664
If we need to workaround this, replace all uses of
WebGLRenderingContext
with the actual constant, e.g.,becomes
@lilleyse let's discuss.
The text was updated successfully, but these errors were encountered: