Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationCollection usability improvements #1188

Closed
pjcozzi opened this issue Sep 25, 2013 · 3 comments
Closed

AnimationCollection usability improvements #1188

pjcozzi opened this issue Sep 25, 2013 · 3 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 25, 2013

In all fairness, AnimationCollection (Sandcastle example) is not complete, but people are using it and it has the potential to bring a lot of coolness to apps. I wrote it in a hurry way before we went open-source.

It needs some re-envisioning and flushing out, but here are a few specific issues from the transit hackathon:

  • An animation needs to be robust if the parent object it is animating is destroyed, e.g., if isDestroyed is true, the animation should remove itself. This is too much for the app to handle.
  • Setting easingFunction for addProperty is too hard. The options are not documented and require reaching into third-party types, e.g., easingFunction : Cesium.Tween.Easing.Cubic.In.
  • Implementing non-trivial things like animating a billboard on mouse over requires way too much state management. Higher-level constructs are needed.
@mramato
Copy link
Contributor

mramato commented Sep 25, 2013

CC #377 (We no longer have the two widgets example, but this is still a problem in the overall animation architecture).

@pjcozzi pjcozzi added the 1.0 label May 8, 2014
This was referenced Jun 3, 2014
@mramato
Copy link
Contributor

mramato commented Jun 24, 2014

@pjcozzi can we close this, or should it just have the 1.0 tag removed after your above PRs?

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jun 24, 2014

All good to close. Anything additional is covered in #1830.

@pjcozzi pjcozzi closed this as completed Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants