Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom ellipsoids in Cesium3DTile bounding volume calculations #11720

Closed
jjhembd opened this issue Dec 22, 2023 · 2 comments
Closed

Support custom ellipsoids in Cesium3DTile bounding volume calculations #11720

jjhembd opened this issue Dec 22, 2023 · 2 comments

Comments

@jjhembd
Copy link
Contributor

jjhembd commented Dec 22, 2023

Feature

Bounding volume calculations in Cesium3DTile currently assume the default WGS84 ellipsoid. These should instead use the ellipsoid associated with the Globe or frameState.mapProjection in case the user has specified a custom ellipsoid.

For tiles with region type bounding volumes, the custom ellipsoid will need to be made available to the Cesium3DTile constructor, which currently does not have access to frameState.

@javagl
Copy link
Contributor

javagl commented Oct 19, 2024

Maybe someone can quickly confirm whether this is obsolete with the recent generalizations from #12000 - I think that most places that assumed WGS84 should have changed to use the one that was configured to be the "default" one, right?

@ggetz
Copy link
Contributor

ggetz commented Oct 21, 2024

For Cesium3DTile, the WGS84 ellipsoid is specifically used throughout when creating the region bounding volumes. However, based on the spec for regions, I don't think this should change when the scene's ellipsoid changes.

I'll close, but please let me know if anyone disagrees.

@ggetz ggetz closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants