Remove decoy checkbox on "Enable Water Mask" #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kring do you mind checking this one since it's Mac related? 😛 |
|
The checkbox is still correctly disabled on the Mac: Also, if I remove all the Mac checks, then the water effect actually works now! This is UE 5.3 on an M4 Max MacBook Pro. I'll write a separate issue for us to consider re-enabling it. |
|
Thanks @azrogers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1538. There's currently a decoy checkbox on "Enable Water Mask" resulting from the
EditConditionflag on the UPROPERTY. I believe this checkbox is actually controlling thebIsMacboolean that theEditConditionflag points to, but not only do we not want this to be a choice the user can make - the system doesn't suddenly become a Mac when the user unchecks the box! - but it also causes confusion between it and the actual "Enable Water Mask" checkbox that truly enables or disables the feature. This change usesCanEditChangeto handle theEditConditioninstead, removing the extra checkbox and also as a side effect removing the need for abIsMaceditor field.