lib: add support for inherited custom inspection methods

PR-URL: nodejs#48306 Fixes: nodejs#48207 Reviewed-By: James M Snell <[email protected]>
Ceres6 · Aug 14, 2023 · 117c65d · 117c65d
1 parent 65a0b58
commit 117c65d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/internal/error_serdes.js b/lib/internal/error_serdes.js
@@ -13,7 +13,6 @@ const {
   ObjectGetOwnPropertyNames,
   ObjectGetPrototypeOf,
   ObjectKeys,
-  ObjectPrototypeHasOwnProperty,
   ObjectPrototypeToString,
   RangeError,
   ReferenceError,
@@ -134,8 +133,7 @@ function serializeError(error) {
     // Continue regardless of error.
   }
   try {
-    if (error != null &&
-      ObjectPrototypeHasOwnProperty(error, customInspectSymbol)) {
+    if (error != null && customInspectSymbol in error) {
       return Buffer.from(StringFromCharCode(kCustomInspectedObject) + inspect(error), 'utf8');
     }
   } catch {

diff --git a/test/parallel/test-error-serdes.js b/test/parallel/test-error-serdes.js
@@ -125,3 +125,11 @@ const data = {
   }
 };
 assert.strictEqual(inspect(cycle(data)), 'barbaz');
+
+const inheritedCustomInspect = new class {
+  foo = 'bar';
+  [inspect.custom]() {
+    return 'barbaz';
+  }
+}();
+assert.strictEqual(inspect(cycle(inheritedCustomInspect)), 'barbaz');