Equatable tweaks #108
Equatable tweaks #108
Conversation
ikesyo
commented
Jul 21, 2018
ikesyo
commented
- Utilize conditional conformances
- Utilize synthesizing Equatable conformance
- Utilize conditional conformances - Utilize synthesizing Equatable conformance
| @@ -33,18 +33,3 @@ extension TaskError: CustomStringConvertible { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| extension TaskError: Equatable { | |||
There was a problem hiding this comment.
is this auto synthesized now? from TaskError: Error, Equatable ?
I saw no tests for this. Do you think it's necessary to add one?
There was a problem hiding this comment.
is this auto synthesized now? from TaskError: Error, Equatable ?
Yes
I saw no tests for this. Do you think it's necessary to add one?
Nah. This is tested in the compiler.
| @@ -88,19 +88,6 @@ extension Task: Hashable { | |||
| } | |||
| } | |||
|
|
|||
| private func ==<Key, Value: Equatable>(lhs: [Key: Value]?, rhs: [Key: Value]?) -> Bool { | |||
There was a problem hiding this comment.
This was removed because of auto inference of equality?
There was a problem hiding this comment.
[Key: Value]? is Equatable automatically now because Optional and Dictionary both have conditional Equatable conformances.
| @@ -33,18 +33,3 @@ extension TaskError: CustomStringConvertible { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| extension TaskError: Equatable { | |||
There was a problem hiding this comment.
is this auto synthesized now? from TaskError: Error, Equatable ?
Yes
I saw no tests for this. Do you think it's necessary to add one?
Nah. This is tested in the compiler.
| @@ -88,19 +88,6 @@ extension Task: Hashable { | |||
| } | |||
| } | |||
|
|
|||
| private func ==<Key, Value: Equatable>(lhs: [Key: Value]?, rhs: [Key: Value]?) -> Bool { | |||
There was a problem hiding this comment.
[Key: Value]? is Equatable automatically now because Optional and Dictionary both have conditional Equatable conformances.
