-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example/Test Model Benchmarks (Canonical WandB runs) #74
Comments
Hey! I'm new to contributing to trlx, would it be worth for me to give this a go for the ppo/ilql sentiment examples? |
@cat-state something like that? vwxyzjn/cleanrl#307 |
Sure, although you might need compute? |
So I see that WandB actually lists the commit hash used for a run. So if we could find/tag TRLX runs in wandb then each commit could be matched up to a specific state of the repository. |
fwiw {ppo,ilql}_config.yml were meant to be single gpu, up to a batch_size, since they both use gpt2 small |
Resolved with #357 |
🚀 The feature, motivation, and pitch
If we had links to benchmarks for the example (and/or test) models, it would be easier to add new models, and keep track of improvements in method implementations. Additionally, during refactoring, it would allow checking that no performance degrading changes were introduced.
This can be a minimal version of #13
Alternatives
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: