Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Policy Decision on BlockedAddrs in SDK v0.50 bump #122

Open
dongsam opened this issue Mar 25, 2024 · 0 comments
Open

[Discussion] Policy Decision on BlockedAddrs in SDK v0.50 bump #122

dongsam opened this issue Mar 25, 2024 · 0 comments

Comments

@dongsam
Copy link
Collaborator

dongsam commented Mar 25, 2024

Context:

Differences and Suggestions:

  1. Gov Module Account:
    • v0.50 simapp allows token receiving in gov module account, not blocked in BlockedAddrs, unlike Canto.
    • This change was due to a refactor!: Refactor CommunityPoolSpendProposal cosmos/cosmos-sdk#12852 aiming to handle CommunityPool -> IBC transfer via gov module account.
    • Suggestion: If no similar case is planned in Canto, keeping gov module in BlockedAddrs might minimize potential risks.
  2. Distribution Module Account:
    • v0.50 simapp disallows token receiving in distribution module account, but Canto currently allows it.
    • This was an exception from Canto's initial setup, with unclear intent.
    • Suggestion: Blocking the distribution module account in BlockedAddrs to minimize risks unless there's an unidentified reason to allow it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant