Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backslash character can't be displayed properly #22

Closed
0x7FFFFFFFFFFFFFFF opened this issue Sep 16, 2022 · 5 comments
Closed

Backslash character can't be displayed properly #22

0x7FFFFFFFFFFFFFFF opened this issue Sep 16, 2022 · 5 comments

Comments

@0x7FFFFFFFFFFFFFFF
Copy link
Contributor

char_issue

I'm on Windows. Not sure if this issue exists on other platforms.

@Canop
Copy link
Owner

Canop commented Sep 17, 2022

I confirm the problem, it's not specific to Windows.

@Canop
Copy link
Owner

Canop commented Sep 20, 2022

This is due to the text being considered as markdown and the parser not being discriminant enough regarding the characters which can be escaped.

@0x7FFFFFFFFFFFFFFF
Copy link
Contributor Author

Interesting. Do you mean SafeCloset actually parse the content in it as markdown? Good to know that. But I mainly store secrets in SafeCloset, which I suppose this tool is designed for. Most secrets are not in markdown format. If this is a note taking tool, markdown is more suitable. Do you think adding an option to disable markdown parsing a good idea? Or disable it by default and only enable it when some parameter is passed to SafeCloset? I don't know, just some options.

@Canop
Copy link
Owner

Canop commented Sep 20, 2022

Options are painful to manage, and it's harder to make sense of behaviors when they change according to local options.

The reason I added markdown support for values is because structured notes are easier to read this way, and safecloset isn't just for passwords.

Now, I agree that markdown rendering is rarely useful in practice in safecloset, I'm not sure it was really a good idea.

I'll start by fixing it, and, afterwards, keeping markdown for values will be another question. It's probable that when this bug is removed nobody will be annoyed by markdown and there will still be some cases it's seen as useful.

@Canop Canop closed this as completed in 546ec78 Sep 20, 2022
@Canop
Copy link
Owner

Canop commented Sep 20, 2022

Fixed in v0.6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants