Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SemanticFormsSelect, Semantic Tasks from composer.canasta.json #274

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

yaronkoren
Copy link
Member

Neither of these extensions contain any Composer dependencies that need to be downloaded.

Neither of these extensions contain any Composer dependencies that need to be downloaded.
@yaronkoren yaronkoren requested review from vedmaka and cicalese August 14, 2023 20:10
@github-actions
Copy link

🐳 The image based on 6edf8733 commit has been built with 1.39.1-20230814-274 tag as ghcr.io/canastawiki/canasta:1.39.1-20230814-274

@yaronkoren yaronkoren merged commit 0b43fc6 into master Aug 15, 2023
@vedmaka
Copy link
Collaborator

vedmaka commented Aug 16, 2023

Both extensions are still downloaded via Git here and here, and not installed via Composer, thus removing both extensions from the composer file breaks them because the autoload sections won't processed anymore [1] [2]. If we want to keep the extensions, we need to remove both from Dockerfile and instead add into https://github.com/CanastaWiki/Canasta-DockerCompose/blob/main/config/composer.local.json sample file require section to allow optional installation

@yaronkoren
Copy link
Member Author

Oh, I didn't realize I need to look at the "autoload" section too. I'll revert this change now.

@cicalese
Copy link
Contributor

But, they both have autoload statements in their extension.json files. They should not need the autoload statements in the composer.json files unless there is something missing from or incorrect in the statements in extension.json. In fact, it is bad form to have autoloading specified in both places and could potentially result in conflicts and confusion. Is there something wrong with the autoload statements in their extension.json files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants